From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([147.243.1.47]:53982 "EHLO mgw-sa01.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753885Ab0K2NCF (ORCPT ); Mon, 29 Nov 2010 08:02:05 -0500 Subject: Re: [RFC 2/2] wl12xx: Stop BA session event from device From: Luciano Coelho To: ext Shahar Levi Cc: "linux-wireless@vger.kernel.org" In-Reply-To: <4CF3A2BE.8040305@ti.com> References: <1290695964-4208-1-git-send-email-shahar_levi@ti.com> <1290695964-4208-2-git-send-email-shahar_levi@ti.com> <1291035211.1673.68.camel@powerslave> <4CF3A2BE.8040305@ti.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Nov 2010 14:58:28 +0200 Message-ID: <1291035508.1673.70.camel@powerslave> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2010-11-29 at 14:55 +0200, ext Shahar Levi wrote: > On 11/29/2010 02:53 PM, Luciano Coelho wrote: > > On Thu, 2010-11-25 at 16:39 +0200, ext Shahar Levi wrote: > >> Adding new event that close RX BA session in case of periodic BT activity > >> limiting WLAN activity. > >> > >> Signed-off-by: Shahar Levi > >> --- > > > > [...] > > > >> diff --git a/drivers/net/wireless/wl12xx/event.c b/drivers/net/wireless/wl12xx/event.c > >> index 9815b7b..7cbeb2b 100644 > >> --- a/drivers/net/wireless/wl12xx/event.c > >> +++ b/drivers/net/wireless/wl12xx/event.c > >> @@ -174,6 +174,25 @@ static void wl1271_event_rssi_trigger(struct wl1271 *wl, > >> wl->last_rssi_event = event; > >> } > >> > >> +static void wl1271_event_ba_rx_constraint(struct wl1271 *wl, > >> + struct event_mailbox *mbox) > >> +{ > >> + u8 tid_index = 0; > >> + > >> + wl1271_debug(DEBUG_EVENT, "BA RX constraint event. ba_allowed = %d", > >> + mbox->ba_allowed); > >> + > >> + wl->ba_allowed = mbox->ba_allowed; > >> + > >> + if (!wl->ba_rx_bitmap) > >> + return; > >> + > >> + for (tid_index = 0; tid_index< CONF_TX_MAX_TID_COUNT; ++tid_index) > > > > Please use the more classic tid_index++ instead. > OK, will be fix on v2. This is really nitpicking now, but if you change tid_index to i instead, you won't need two lines for the call to ieee80211_stop_rx_ba_session(), because it will fit in one line. :P -- Cheers, Luca.