From: Johannes Berg <johannes@sipsolutions.net>
To: Johannes Stezenbach <js@sig21.net>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <IvDoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v2 RFC] mac80211: fix "NOHZ: local_softirq_pending 08"
Date: Mon, 29 Nov 2010 16:58:40 +0100 [thread overview]
Message-ID: <1291046320.3532.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101129155126.GA32482@sig21.net>
On Mon, 2010-11-29 at 16:51 +0100, Johannes Stezenbach wrote:
> -void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
> +void __ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb,
> + int (*netif_rx_func)(struct sk_buff *skb))
This seems weird to me -- why not just do
static inline void ieee80211_tx_status_ni(...)
{
local_bh_disable();
ieee80211_tx_status(...);
local_bh_enable();
}
johannes
next prev parent reply other threads:[~2010-11-29 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:54 [PATCH RFC] mac80211: fix "NOHZ: local_softirq_pending 08" Johannes Stezenbach
2010-11-29 15:09 ` Johannes Berg
2010-11-29 15:27 ` Johannes Stezenbach
2010-11-29 15:37 ` Johannes Berg
2010-11-29 15:51 ` [PATCH v2 " Johannes Stezenbach
2010-11-29 15:58 ` Johannes Berg [this message]
2010-11-29 16:13 ` [PATCH v3 RFC] mac80211: add ieee80211_tx_status_ni() Johannes Stezenbach
2010-11-30 15:49 ` [PATCH v4] mac80211/rt2x00: " Johannes Stezenbach
2010-11-30 15:53 ` Johannes Berg
2010-11-30 16:34 ` Johannes Stezenbach
2010-11-30 16:35 ` Johannes Berg
2010-11-30 18:38 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291046320.3532.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=js@sig21.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).