From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Ohad Ben-Cohen <ohad@wizery.com>
Cc: Shahar Levi <shahar_levi@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 ] wl12xx: BA Initiator support
Date: Tue, 30 Nov 2010 08:11:40 +0200 [thread overview]
Message-ID: <1291097500.1673.100.camel@powerslave> (raw)
In-Reply-To: <AANLkTikUOfQbk-TEE2=EejXOTr_t-LXvTim-Sc1OVwKG@mail.gmail.com>
On Mon, 2010-11-29 at 16:44 -0800, ext Ohad Ben-Cohen wrote:
> Hi Shahar,
>
> On Mon, Nov 29, 2010 at 5:42 AM, Shahar Levi <shahar_levi@ti.com> wrote:
> ...
> > -#define WL1271_FW_NAME "wl1271-fw.bin"
> > +#define WL1271_FW_NAME "wl1271-fw-2.bin"
>
> Changing the firmware's major version involves usability and
> maintainability pain to the entire wl12xx community, especially if
> done repeatedly, and therefore should be generally avoided.
Yes, I was thinking about the same thing yesterday. Then I had to
leave, so I'm still not sure whether this is really needed.
> When the firmware API changes, and the old driver can't work with it
> anymore, then you have no choice but changing the name.
In theory the API *has* changed, not just extended. Check this:
- ACX_BA_SESSION_RESPONDER_POLICY = 0x0055,
- ACX_BA_SESSION_INITIATOR_POLICY = 0x0056,
+ ACX_BA_SESSION_POLICY_CFG = 0x0055,
+ ACX_BA_SESSION_RX_SETUP = 0x0056,
But in practice, this doesn't matter, because we were not using the
RESPONDER/INITIATOR commands before...
> But if it's just a small API extension enabling new driver
> functionality, you should really avoid bumping the firmware version,
> and instead try to dynamically detect it from the driver and act
> appropriately.
>
> Please explain what has exactly been changed in the firmware and let's
> try to find a clean solution.
It's basically just those two extra commands that were added. And one
new event that is part of a future patch.
In theory, we could check the firmware revision after boot and bail out
if the version doesn't match. Maybe we should add a small
infrastructure for that kind of check.
This new firmware is only required if 11n is enabled too, so at least we
should not have the driver fail whe the new fw version is not there,
unless 11n is enabled.
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-11-30 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 13:42 [PATCH v4 ] wl12xx: BA Initiator support Shahar Levi
2010-11-30 0:44 ` Ohad Ben-Cohen
2010-11-30 6:11 ` Luciano Coelho [this message]
2010-11-30 7:07 ` Ohad Ben-Cohen
2010-11-30 7:15 ` Luciano Coelho
2010-11-30 9:06 ` Shahar Levi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291097500.1673.100.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=shahar_levi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).