From: Joe Perches <joe@perches.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@lists.ath9k.org, peter@stuge.se,
linux-kernel@vger.kernel.org
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug
Date: Wed, 01 Dec 2010 06:27:55 -0800 [thread overview]
Message-ID: <1291213675.1845.12.camel@Joe-Laptop> (raw)
In-Reply-To: <AANLkTik2qtGUgkZYSjcEH9jHHsevKnxOvz4s6On94U9o@mail.gmail.com>
On Tue, 2010-11-30 at 23:56 -0800, Luis R. Rodriguez wrote:
> On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches <joe@perches.com> wrote:
> > Poor function naming is just that.
> > It reduces readability and the uses are counter expectation.
> The name is perfect, we use it to print anything, even non-debugging stuff.
'fraid not.
ath/debug.h
#ifdef CONFIG_ATH_DEBUG
void ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
__attribute__ ((format (printf, 3, 4)));
#else
static inline void __attribute__ ((format (printf, 3, 4)))
ath_print(struct ath_common *common, int dbg_mask, const char *fmt, ...)
{
}
#endif /* CONFIG_ATH_DEBUG */
next prev parent reply other threads:[~2010-12-01 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 23:53 [PATCH wireless-next] ath: Rename ath_print to ath_debug Joe Perches
2010-11-29 2:17 ` Luis R. Rodriguez
[not found] ` <20101129060732.5130.qmail@stuge.se>
2010-11-29 22:41 ` [ath9k-devel] " Felix Fietkau
2010-11-29 22:42 ` Luis R. Rodriguez
2010-11-30 1:39 ` Joe Perches
2010-11-30 2:43 ` Felix Fietkau
2010-11-30 20:19 ` Joe Perches
2010-12-01 7:56 ` Luis R. Rodriguez
2010-12-01 7:59 ` Luis R. Rodriguez
2010-12-01 14:27 ` Joe Perches [this message]
2010-12-01 14:37 ` Felix Fietkau
2010-12-01 17:17 ` Joe Perches
2010-12-01 17:28 ` Joe Perches
2010-12-01 17:44 ` [PATCH] ath: Add and use ath_printk and ath_<level> Joe Perches
2010-12-01 18:05 ` [PATCH V2] " Joe Perches
2010-12-01 19:08 ` [PATCH] ath: Convert ath_print(.., ATH_DBG_FATAL to ath_err Joe Perches
2010-12-01 17:37 ` [PATCH wireless-next] MAINTAINERS: Add ATH GENERIC UTILITIES Joe Perches
2010-12-01 19:46 ` Luis R. Rodriguez
2010-12-01 20:16 ` Joe Perches
2010-12-01 20:18 ` Luis R. Rodriguez
2010-12-01 20:41 ` [ath9k-devel] " Luis R. Rodriguez
2010-12-02 0:48 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291213675.1845.12.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
--cc=peter@stuge.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).