From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Amod Bodas <Amod.Bodas@atheros.com>,
"pstew@google.com" <pstew@google.com>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH 5/5] mac80211: fix issuing idle calls when device open count is 0
Date: Tue, 07 Dec 2010 19:12:47 +0100 [thread overview]
Message-ID: <1291745567.3607.52.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTi=Sj7YpKzFHQtf2MdUcRDTzfXszbK7gGg_yup1Y@mail.gmail.com>
On Tue, 2010-12-07 at 10:04 -0800, Luis R. Rodriguez wrote:
> On Tue, Dec 7, 2010 at 9:32 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2010-12-07 at 07:59 -0800, Luis R. Rodriguez wrote:
> >
> >> @@ -301,7 +301,7 @@ static void __ieee80211_scan_completed_finish(struct ieee80211_hw *hw,
> >> }
> >>
> >> mutex_lock(&local->mtx);
> >> - ieee80211_recalc_idle(local);
> >> + ieee80211_recalc_idle_force(local);
> >> mutex_unlock(&local->mtx);
> >
> > This is the change that I don't think is necessary.
>
> Without this resume fails.
In what situation? When you just suspend while things are up&running, or
if you suspend with interfaces down? It doesn't make sense anyway, so
something's going on in the rest of the scan code -- we should be
canceling scans properly when going down and when suspending, well
before any of this becomes relevant.
johannes
next prev parent reply other threads:[~2010-12-07 18:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 2:48 [PATCH 0/5] mac80211/ath9k: few suspend checks and fixes Luis R. Rodriguez
2010-12-07 2:48 ` [PATCH 1/5] ath9k: warn when we get a ATH9K_INT_TIM_TIMER and are idle Luis R. Rodriguez
2011-01-19 1:34 ` Ben Greear
2011-01-19 1:38 ` Luis R. Rodriguez
2011-01-19 1:42 ` Ben Greear
2011-01-19 1:43 ` Luis R. Rodriguez
2010-12-07 2:48 ` [PATCH 2/5] ath9k: Fix power save count imbalance on ath_radio_enable() Luis R. Rodriguez
2010-12-07 2:48 ` [PATCH 3/5] ath9k_hw: warn if we cannot change the power to the chip Luis R. Rodriguez
2010-12-07 2:48 ` [PATCH 4/5] mac80211: fix idle change notifications upon device stop Luis R. Rodriguez
2010-12-07 2:48 ` [PATCH 5/5] mac80211: fix issuing idle calls when device open count is 0 Luis R. Rodriguez
2010-12-07 9:38 ` Johannes Berg
2010-12-07 15:20 ` Paul Stewart
2010-12-07 15:23 ` Johannes Berg
2010-12-07 17:28 ` Paul Stewart
2010-12-07 17:31 ` Johannes Berg
2010-12-07 15:44 ` Luis R. Rodriguez
2010-12-07 15:48 ` Johannes Berg
2010-12-07 15:51 ` Luis R. Rodriguez
2010-12-07 15:54 ` Johannes Berg
2010-12-07 15:59 ` Luis R. Rodriguez
2010-12-07 17:32 ` Johannes Berg
2010-12-07 18:04 ` Luis R. Rodriguez
2010-12-07 18:12 ` Johannes Berg [this message]
2010-12-07 20:49 ` Luis R. Rodriguez
2010-12-07 20:54 ` Johannes Berg
2010-12-07 20:56 ` Luis R. Rodriguez
2010-12-07 20:57 ` Johannes Berg
2010-12-07 21:28 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291745567.3607.52.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Amod.Bodas@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=pstew@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).