From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Ben Greear <greearb@candelatech.com>
Subject: Re: [PATCH] ath: fix build break with ATH_DBG_WARN_ON_ONCE
Date: Thu, 09 Dec 2010 15:17:52 +0100 [thread overview]
Message-ID: <1291904272.3540.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1291903927-5406-1-git-send-email-linville@tuxdriver.com>
On Thu, 2010-12-09 at 09:12 -0500, John W. Linville wrote:
> diff --git a/drivers/net/wireless/ath/ath.h b/drivers/net/wireless/ath/ath.h
> index 3eb95e2..45d4d91 100644
> --- a/drivers/net/wireless/ath/ath.h
> +++ b/drivers/net/wireless/ath/ath.h
> @@ -272,7 +272,7 @@ ath_dbg(struct ath_common *common, enum ATH_DEBUG dbg_mask,
> return 0;
> }
> #define ATH_DBG_WARN(foo, arg...) do {} while (0)
> -#define ATH_DBG_WARN_ON_ONCE(foo) do {} while (0)
> +#define ATH_DBG_WARN_ON_ONCE(foo) ({ 0; })
That'll fix the build error, but wouldn't you need (foo) for correctness
instead?
johannes
next prev parent reply other threads:[~2010-12-09 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 13:47 Compile problem in ath9k with ATH_DBG_WARN_ON_ONCE Hauke Mehrtens
2010-12-09 14:12 ` [PATCH] ath: fix build break " John W. Linville
2010-12-09 14:17 ` Johannes Berg [this message]
2010-12-09 14:42 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291904272.3540.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).