From: Johannes Berg <johannes@sipsolutions.net>
To: luciano.coelho@nokia.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v2 0/2] implementation of scheduled scan
Date: Fri, 10 Dec 2010 21:17:03 +0100 [thread overview]
Message-ID: <1292012223.3531.32.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1292010802.3531.6.camel@jlt3.sipsolutions.net>
On Fri, 2010-12-10 at 20:53 +0100, Johannes Berg wrote:
> On Fri, 2010-12-10 at 17:07 +0200, luciano.coelho@nokia.com wrote:
>
> > * I kept the return value in the sched_scan_stop chain, because, at least with
> > wl12xx, the call can fail (due to OOM for instance). I think it's cleaner
> > this way.
>
> What's going to happen then though? Would it make sense to pre-allocate
> this at start() time, so it can cleanly stop regardless of what's going
> on? I can see start() failing, but stop() failing seems a bit hard to
> work with in wpa_supplicant?
Actually so the nl80211 interface has to be able to return something
like "no such operation in progress" or whatever, but I'm not sure about
the driver interface -- -ENOMEM seems like a stupid failure for stopping
something, and then the above applies ...
johannes
next prev parent reply other threads:[~2010-12-10 20:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-10 15:07 [RFC v2 0/2] implementation of scheduled scan luciano.coelho
2010-12-10 15:07 ` [RFC v2 1/2] cfg80211/nl80211: add support for scheduled scans luciano.coelho
2010-12-10 20:03 ` Johannes Berg
2010-12-13 14:04 ` Luciano Coelho
2010-12-10 20:05 ` Johannes Berg
2010-12-13 15:30 ` Luciano Coelho
2010-12-10 15:07 ` [RFC v2 2/2] mac80211: add support for HW scheduled scan luciano.coelho
2010-12-10 20:15 ` Johannes Berg
2010-12-14 16:06 ` Luciano Coelho
2010-12-10 19:53 ` [RFC v2 0/2] implementation of " Johannes Berg
2010-12-10 20:17 ` Johannes Berg [this message]
2010-12-13 16:13 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292012223.3531.32.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).