From: Felix Fietkau <nbd@openwrt.org>
To: linux-wireless@vger.kernel.org
Cc: linville@tuxdriver.com, lrodriguez@atheros.com,
vasanth@atheros.com, Felix Fietkau <nbd@openwrt.org>
Subject: [PATCH v2 2/7] ath9k_hw: fix the slot time setting for long distance links
Date: Mon, 13 Dec 2010 08:40:51 +0100 [thread overview]
Message-ID: <1292226056-56008-2-git-send-email-nbd@openwrt.org> (raw)
In-Reply-To: <1292226056-56008-1-git-send-email-nbd@openwrt.org>
Testing shows that adjusting the slot time based on the coverage class
produces very high latencies and very low throughput on long distance links.
Adjusting only the ACK timeout and leaving the slot time at the regular
values - while technically not optimal for CSMA - works a lot better on
long links (tested with 10 km distance)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
drivers/net/wireless/ath/ath9k/hw.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index 856a76e..3c8db81 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -808,7 +808,7 @@ void ath9k_hw_init_global_settings(struct ath_hw *ah)
if (conf->channel && conf->channel->band == IEEE80211_BAND_2GHZ)
acktimeout += 64 - sifstime - ah->slottime;
- ath9k_hw_setslottime(ah, slottime);
+ ath9k_hw_setslottime(ah, ah->slottime);
ath9k_hw_set_ack_timeout(ah, acktimeout);
ath9k_hw_set_cts_timeout(ah, acktimeout);
if (ah->globaltxtimeout != (u32) -1)
--
1.7.3.2
next prev parent reply other threads:[~2010-12-13 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 7:40 [PATCH v2 1/7] ath9k_hw: initialize ah->slottime Felix Fietkau
2010-12-13 7:40 ` Felix Fietkau [this message]
2010-12-13 7:40 ` [PATCH v2 3/7] ath9k: fix PA predistortion thermal measurement handling Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 4/7] ath9k_hw: fix the PA predistortion rate mask Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 5/7] ath9k_hw: fix PA predistortion training power selection Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 6/7] ath9k_hw: update AR9003 initvals for improved radar detection Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 7/7] ath9k_hw: update AR9003 initvals to improve carrier leak calibration/correction Felix Fietkau
2010-12-13 10:52 ` [PATCH v2 5/7] ath9k_hw: fix PA predistortion training power selection Christian Lamparter
2010-12-13 10:20 ` Johannes Berg
2010-12-13 11:28 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292226056-56008-2-git-send-email-nbd@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).