From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add notification for dropped Deauth/Disassoc
Date: Tue, 14 Dec 2010 08:48:22 +0100 [thread overview]
Message-ID: <1292312902.3569.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101214074653.GA28072@jm.kir.nu>
On Tue, 2010-12-14 at 09:46 +0200, Jouni Malinen wrote:
> On Tue, Dec 14, 2010 at 08:15:07AM +0100, Johannes Berg wrote:
> > On Tue, 2010-12-14 at 00:00 +0200, Jouni Malinen wrote:
> > > + * @NL80211_CMD_UNPROT_DEAUTHENTICATE: Unprotected deauthentication frame
> > > + * @NL80211_CMD_UNPROT_DISASSOCIATE: Unprotected disassociation frame
> >
> > I don't mind, but if we add the frame body should we really have two
> > commands? Or should we have just one? Are we likely to need similar
> > functionality for other frames? The only ones I can think of are class 3
> > frames from unassociated stations, but that seems like it should be
> > separate anyway.
>
> This one followed the existing example of NL80211_CMD_DEAUTH/DISASSOC,
> but well, those are for both notification and requests, so I can see the
> difference there.. For these notification-only ones, I would be fine
> having a single command if that is desirable. Though, I would probably
> not go as far as merging any other frames to this list since
> deauth/disassoc are special case for the AP starting to send these as
> replies to any Class 2 or 3 frame.
Ok. I don't think we really need to go to a single command, and this may
be more helpful for drivers that might not be able to give us the frame
at all due to firmware implementation, so maybe it's better to keep it
as is and not rely on the frame in wpa_s.
johannes
next prev parent reply other threads:[~2010-12-14 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:00 [PATCH] nl80211: Add notification for dropped Deauth/Disassoc Jouni Malinen
2010-12-14 7:15 ` Johannes Berg
2010-12-14 7:46 ` Jouni Malinen
2010-12-14 7:48 ` Johannes Berg [this message]
2010-12-14 7:51 ` Johannes Berg
2010-12-14 7:54 ` Johannes Berg
2010-12-14 8:41 ` [PATCH v2] " Jouni Malinen
2010-12-15 21:56 ` John W. Linville
2010-12-15 22:49 ` Jouni Malinen
2010-12-15 22:52 ` [PATCH v3] " Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292312902.3569.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).