From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add notification for dropped Deauth/Disassoc
Date: Tue, 14 Dec 2010 08:51:51 +0100 [thread overview]
Message-ID: <1292313111.3569.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20101213220048.GA24752@jm.kir.nu>
On Tue, 2010-12-14 at 00:00 +0200, Jouni Malinen wrote:
> @@ -1539,12 +1539,30 @@ ieee80211_drop_unencrypted_mgmt(struct i
> if (rx->sta && test_sta_flags(rx->sta, WLAN_STA_MFP)) {
> if (unlikely(!ieee80211_has_protected(fc) &&
> ieee80211_is_unicast_robust_mgmt_frame(rx->skb) &&
> - rx->key))
> + rx->key)) {
> + if (ieee80211_is_deauth(fc))
> + cfg80211_send_unprot_deauth(rx->sdata->dev,
> + rx->skb->data,
> + rx->skb->len);
This is the RX path.
> +void cfg80211_send_unprot_disassoc(struct net_device *dev, const u8 *buf,
> + size_t len)
> +{
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> + struct wiphy *wiphy = wdev->wiphy;
> + struct cfg80211_registered_device *rdev = wiphy_to_dev(wiphy);
> +
> + wdev_lock(wdev);
> + nl80211_send_unprot_disassoc(rdev, dev, buf, len, GFP_KERNEL);
And this uses GFP_KERNEL. Surely that can't be right?
johannes
next prev parent reply other threads:[~2010-12-14 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 22:00 [PATCH] nl80211: Add notification for dropped Deauth/Disassoc Jouni Malinen
2010-12-14 7:15 ` Johannes Berg
2010-12-14 7:46 ` Jouni Malinen
2010-12-14 7:48 ` Johannes Berg
2010-12-14 7:51 ` Johannes Berg [this message]
2010-12-14 7:54 ` Johannes Berg
2010-12-14 8:41 ` [PATCH v2] " Jouni Malinen
2010-12-15 21:56 ` John W. Linville
2010-12-15 22:49 ` Jouni Malinen
2010-12-15 22:52 ` [PATCH v3] " Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292313111.3569.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).