From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Eliad Peller <eliad@wizery.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: allow runtime changing of debug_level
Date: Wed, 15 Dec 2010 15:15:50 +0200 [thread overview]
Message-ID: <1292418950.32385.4.camel@chilepepper> (raw)
In-Reply-To: <1292148935-8709-1-git-send-email-eliad@wizery.com>
On Sun, 2010-12-12 at 12:15 +0200, ext Eliad Peller wrote:
> Currently, the debug level is set in compilation time (by the DEBUG_LEVEL
> const). This method has the advantage of compiling only the relevant
> messages, while optimizing out the unused ones.
>
> In order to allow runtime control over the debug_level, while optimizing
> out messages when debug messages are not needed, we combine some methods:
> 1. use dynamic_debug (pr_debug) rather then printk.
> 2. add debug_level module param in order to set debug level during insmod.
> 3. add debug_level sysfs file in order to allow dynamic control over the
> debug level.
>
> Since patches for pr_debug_hex_dump() implementation haven't been applied yet,
> we are still temporarly using print_hex_dump().
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Applied, thanks!
--
Cheers,
Luca.
prev parent reply other threads:[~2010-12-15 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 10:15 [PATCH] wl12xx: allow runtime changing of debug_level Eliad Peller
2010-12-15 13:15 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292418950.32385.4.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox