From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 00/22] rtl8192ce: Initial upload of driver
Date: Wed, 15 Dec 2010 17:26:40 +0100 [thread overview]
Message-ID: <1292430400.3678.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4D08EA6D.6070106@lwfinger.net>
Larry,
> If you prefer that it go to staging first, I will send it to GregKH, but since
> it uses mac80211, I think it is ready for wireless.
It looks pretty clean -- so personally, I don't think I'd mind it going
in directly.
Are you or somebody else planning to make changes to it though? It looks
like for example the config semaphore could easily be replaced by a
mutex for better debug, for example. Potentially, rate control could be
internalised with IEEE80211_HW_HAS_RATE_CONTROL as well, and some
similar minor things.
johannes
next prev parent reply other threads:[~2010-12-15 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 16:18 [PATCH 00/22] rtl8192ce: Initial upload of driver Larry Finger
2010-12-15 16:26 ` Johannes Berg [this message]
2010-12-15 16:37 ` John W. Linville
2010-12-15 17:12 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 17:12 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292430400.3678.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).