Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <linville@tuxdriver.com>
Cc: <linux-wireless@vger.kernel.org>,
	"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 0/2] cfg80211/ath: custom regulatory bug fixes
Date: Wed, 15 Dec 2010 19:24:10 -0800	[thread overview]
Message-ID: <1292469852-2987-1-git-send-email-lrodriguez@atheros.com> (raw)

Here are a couple of fixes for the recent change we did where we
moved the core regulatory hint to the queue. In a really slow box
or if you are doing crazy testing this can potentilly occur. I take
it the patch "cfg80211: put core regulatory request into queue"
will note make it in until 2.6.38, so these are not a stable fixes.

I was able to force the condition by doing:

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 99d4183..e6f483d0 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1481,7 +1481,7 @@ static void reg_process_pending_hints(void)
 
 	spin_unlock(&reg_requests_lock);
 
-	reg_process_hint(reg_request);
+	//reg_process_hint(reg_request);
 
 out:
 	mutex_unlock(&reg_mutex);

This mimics the situation of either having a slow box or you
doing some crazy module load/unload testing.

Luis R. Rodriguez (2):
  cfg80211: fix null pointer dereference with a custom regulatory
    request
  ath: fix NULL pointer dereference on reg_notifier()

 drivers/net/wireless/ath/regd.c |    8 ++++++++
 include/net/cfg80211.h          |    4 +++-
 net/wireless/reg.c              |    3 ++-
 3 files changed, 13 insertions(+), 2 deletions(-)

-- 
1.7.3.2.90.gd4c43


             reply	other threads:[~2010-12-16  3:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16  3:24 Luis R. Rodriguez [this message]
2010-12-16  3:24 ` [PATCH 1/2] cfg80211: fix null pointer dereference with a custom regulatory request Luis R. Rodriguez
2010-12-16  3:24 ` [PATCH 2/2] ath: fix NULL pointer dereference on reg_notifier() Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292469852-2987-1-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox