From: Ben Hutchings <ben@decadent.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Julien Cristau <jcristau@debian.org>,
599345@bugs.debian.org, ilw@linux.intel.com,
linux-wireless@vger.kernel.org
Subject: Re: Bug#599345: linux-image-2.6.32-5-amd64: iwlagn allocation failure
Date: Wed, 22 Dec 2010 04:11:44 +0000 [thread overview]
Message-ID: <1292991104.2874.26.camel@localhost> (raw)
In-Reply-To: <1286983826.3640.57.camel@jlt3.sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Wed, 2010-10-13 at 17:30 +0200, Johannes Berg wrote:
> On Wed, 2010-10-13 at 17:17 +0200, Julien Cristau wrote:
>
> > Getting lots of those in dmesg:
> > iwlagn 0000:0c:00.0: Too many chunks: 2
> >
> > Doesn't seem to prevent the network from working though.
>
> It'll at least leak lots of memory though. But I think the check there
> is just wrong -- there are TFDs, and there are SKBs, and we need two
> TFDs, but just one SKB.
Right. The old condition:
if (num_tbs >= IWL_NUM_OF_TBS) {
should have been:
if (num_tbs > IWL_NUM_OF_TBS) {
though in practice neither condition was possible.
In the minimal patch, the condition should be changed to:
if (num_tbs > 2) {
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2010-12-22 4:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101006191947.GA3036@radis.liafa.jussieu.fr>
2010-10-06 21:54 ` Bug#599345: linux-image-2.6.32-5-amd64: iwlagn allocation failure Ben Hutchings
2010-10-07 7:51 ` Johannes Berg
2010-10-10 19:03 ` Ben Hutchings
2010-10-10 19:37 ` Johannes Berg
2010-10-13 15:17 ` Julien Cristau
2010-10-13 15:30 ` Johannes Berg
2010-12-22 4:11 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292991104.2874.26.camel@localhost \
--to=ben@decadent.org.uk \
--cc=599345@bugs.debian.org \
--cc=ilw@linux.intel.com \
--cc=jcristau@debian.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).