Re: [PATCH 1/2] cfg80211: process new country regulatory flags (DFS)

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2010-12-20 at 12:02 -0500, Luis R. Rodriguez wrote:

> --- a/include/linux/nl80211.h
> +++ b/include/linux/nl80211.h
> @@ -858,6 +858,9 @@ enum nl80211_commands {
>   *	attributes, specifying what a key should be set as default as.
>   *	See &enum nl80211_key_default_types.
>   *
> + * @NL80211_ATTR_REG_COUNTRY_FLAGS: Country specific regulatory flags.
> + *	These are @NL80211_CFLAG_DFS_*
> + *

Please also add a note "(u16)" here or so.

> +#define flag_check_print(_str) \
> +	do { \
> +		if (has_flag) \
> +			pr_info(", "); \
> +		pr_info(_str); \
> +		has_flag = true; \
> +	} while (0)
> +
> +static void print_country_flags(u16 flags)
> +{

Can you move the define into the function, and also #undef it please?

Also -- it seems that this is never reported back to be printed by iw
reg get? I think that might be needed? If you do, it should only report
the ones that the kernel knows about (i.e. mask them with the _ALL
thing)

Does it make sense to actually have this a bitmask rather than an enum?
Do we think there's some place that needs _multiple_ rules?

johannes