From: Johannes Berg <johannes@sipsolutions.net>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC] mac80211: ignore PSM bit of reordered frames
Date: Mon, 27 Dec 2010 11:58:47 +0100 [thread overview]
Message-ID: <1293447527.3544.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <E1PWwiD-0003TF-Oo@debian64.daheim>
On Sun, 2010-12-26 at 20:56 +0100, Christian Lamparter wrote:
> This patch tackles one of the problems of my
> reorder release timer patch from August.
>
> <http://www.spinics.net/lists/linux-wireless/msg57214.html>
> =>
> What if the reorder release triggers and ap_sta_ps_end
> (called by ieee80211_rx_h_sta_process) accidentally clears
> the WLAN_STA_PS_STA flag, because 100ms ago - when the STA
> was still active - frames were put into the reorder buffer.
>
> Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
> ---
> Alternatively, we could flush the per-tid STA reorder buffer
> content in ap_sta_ps_start, so the buffer is empty.
> + * @IEEE80211_RX_DEFERED_RELEASE: frame was subjected to receive reordering
I'm ok with this, but please spell it "deferred" :-)
johannes
prev parent reply other threads:[~2010-12-27 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 19:56 [RFC] mac80211: ignore PSM bit of reordered frames Christian Lamparter
2010-12-27 10:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293447527.3544.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox