linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luciano Coelho <coelho@ti.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arik Nemtsov <arik@wizery.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wl12xx: reset 5ghz num channels on hw init
Date: Tue, 11 Jan 2011 10:32:18 +0200	[thread overview]
Message-ID: <1294734738.12992.45.camel@pimenta> (raw)
In-Reply-To: <1294734327.3611.1.camel@jlt3.sipsolutions.net>

Hi Johannes,

On Tue, 2011-01-11 at 09:25 +0100, Johannes Berg wrote:
> On Mon, 2011-01-10 at 23:04 +0200, Arik Nemtsov wrote:
> > The number of 5ghz channels is set to 0 when 11a is not supported in the
> > NVS file. When a single rmmod/insmod of wl12xx_sdio this leads to a
> > supported band (5ghz) with 0 supported channels, which mac80211
> > considers illegal.
> 
> The setting to 0 shouldn't be happening in a global structure anyway
> since that way you can't support two different devices in the same
> system!!

This is that hack we discussed some time ago on how to disable the 11a
channels.  We only know that they're not supported after the driver is
loaded and the supported channels are already registered.  We get the
info that the 11a are not supported in the calibration data that we
receive later.

See commit fb6a6819fad0d71b47577a51709440a9f8441f0a.

Earlier I was disabling the channels by setting the DISABLED flag, but
that was bad, because I was touching regulatory stuff and it was causing
other problems.

-- 
Cheers,
Luca.


  reply	other threads:[~2011-01-11  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 21:04 [PATCH] wl12xx: reset 5ghz num channels on hw init Arik Nemtsov
2011-01-11  8:25 ` Johannes Berg
2011-01-11  8:32   ` Luciano Coelho [this message]
2011-01-11  8:36     ` Johannes Berg
2011-01-11  8:53       ` Luciano Coelho
2011-01-11 17:37 ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294734738.12992.45.camel@pimenta \
    --to=coelho@ti.com \
    --cc=arik@wizery.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).