From: Johannes Berg <johannes@sipsolutions.net>
To: jpo234 <pommnitz@yahoo.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/4] iw: Add channel busy time to survey
Date: Tue, 11 Jan 2011 14:00:36 +0100 [thread overview]
Message-ID: <1294750836.3611.25.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <loom.20110111T135315-64@post.gmane.org>
On Tue, 2011-01-11 at 12:57 +0000, jpo234 wrote:
> Johannes Berg <johannes@...> writes:
> > because uint64_t isn't guaranteed to be unsigned long long (in fact, it
> > is unsigned long on many machines). Please look at the commit and check.
>
> In the commit you did a cast to unsigned long long. While this works, it's
> depends on gcc-ism, e.g. long long support. The C99 way would be to use the
> PRIu64 macro (see stdint.h).
> see http://www.dinkumware.com/manuals/?manual=compleat&page=inttypes.html#PRIu64
Oi, that's complicated. Patch welcome I guess.
johannes
next prev parent reply other threads:[~2011-01-11 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 0:51 [PATCH v2 1/4] iw: survey: Mark frequency in use Bruno Randolf
2011-01-11 0:51 ` [PATCH v2 2/4] iw: Add channel busy time to survey Bruno Randolf
2011-01-11 8:32 ` Johannes Berg
2011-01-11 9:20 ` Bruno Randolf
2011-01-11 12:57 ` jpo234
2011-01-11 13:00 ` jpo234
2011-01-11 13:00 ` Johannes Berg [this message]
2011-01-11 13:08 ` jpo234
2011-01-11 0:51 ` [PATCH v2 3/4] iw: add multicast rates to IBSS join Bruno Randolf
2011-01-11 0:51 ` [PATCH v2 4/4] iw: Add signal average to station dump information Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294750836.3611.25.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pommnitz@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).