From: Johannes Berg <johannes@sipsolutions.net>
To: coelho@ti.com
Cc: linux-wireless@vger.kernel.org, juuso.oikarinen@nokia.com
Subject: Re: [PATCH 1/2] mac80211: add hw configuration for max ampdu buffer size
Date: Wed, 12 Jan 2011 13:46:46 +0100 [thread overview]
Message-ID: <1294836406.3639.25.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1294836052-16828-1-git-send-email-coelho@ti.com>
On Wed, 2011-01-12 at 14:40 +0200, coelho@ti.com wrote:
> From: Luciano Coelho <coelho@ti.com>
>
> Some devices don't support the maximum AMDPU buffer size of 64, so we
> need to add an option to configure this in the hardware configuration.
> This value will be used in the ADDBA response instead of the value
> suggested in the request, if the latter is greater than the max
> supported.
>
> Signed-off-by: Luciano Coelho <coelho@ti.com>
> ---
> include/net/mac80211.h | 4 ++++
> net/mac80211/agg-rx.c | 3 +++
> net/mac80211/main.c | 1 +
> 3 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 5b3fd5a..1341d82 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -1143,6 +1143,9 @@ enum ieee80211_hw_flags {
> * @napi_weight: weight used for NAPI polling. You must specify an
> * appropriate value here if a napi_poll operation is provided
> * by your driver.
> + * @max_rx_aggregation_subframes: maximum buffer size (number of
> + * sub-frames) to be used for A-MPDU block ack receiver
> + * aggregation.
... "This is only relevant if the device has restrictions on the number
of subframes, if it relies on mac80211 to do reordering it shouldn't be
set." maybe?
johannes
next prev parent reply other threads:[~2011-01-12 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 12:40 [PATCH 1/2] mac80211: add hw configuration for max ampdu buffer size coelho
2011-01-12 12:40 ` [PATCH 2/2] wl12xx: add hw configuration for max supported AMDPU size coelho
2011-01-12 12:43 ` [PATCH 1/2] mac80211: add hw configuration for max ampdu buffer size Luciano Coelho
2011-01-12 12:46 ` Johannes Berg [this message]
2011-01-12 13:04 ` Luciano Coelho
2011-01-12 12:57 ` Juuso Oikarinen
2011-01-12 13:05 ` Luciano Coelho
2011-01-12 13:10 ` Juuso Oikarinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294836406.3639.25.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).