From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: Luciano Coelho <coelho@ti.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wl12xx: fix some sparse warnings
Date: Sun, 16 Jan 2011 09:52:20 +0100 [thread overview]
Message-ID: <1295167940.3574.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTi=pizkixzqiiHwcN6KjcB-+oiKbsmo3TOw_bCB6@mail.gmail.com>
On Sun, 2011-01-16 at 10:48 +0200, Eliad Peller wrote:
> >> - acx->rate_policy_idx = idx;
> >> + acx->rate_policy_idx = __cpu_to_le32(idx);
> >
> > The underscore version doesn't look appropriate at this point or in fact
> > anywhere in this patch.
> >
> > Also, your patch subject and commit log is wrong -- this doesn't just
> > fix sparse warnings, it fixes actual bugs pointed out by sparse, so
> > commit log should reflect that.
> >
> thanks for your review!
> i'll send a new version.
>
> what is the difference between the normal and underscore version?
> atomicity? (i didn't find a documentation about it)
Generally underscore versions are more "internal" APIs. In this case, I
believe the underscore version is usable in places where the compiler
needs a constant as the output, I'm not quite sure though.
johannes
next prev parent reply other threads:[~2011-01-16 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 7:49 [PATCH] wl12xx: fix some sparse warnings Eliad Peller
2011-01-16 8:28 ` Johannes Berg
2011-01-16 8:48 ` Eliad Peller
2011-01-16 8:52 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-22 11:38 Eliad Peller
2011-01-10 16:02 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295167940.3574.11.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=coelho@ti.com \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).