* [PATCH] mac80211: allow advertising correct maximum aggregate size
@ 2011-01-18 12:52 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2011-01-18 12:52 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless@vger.kernel.org
From: Johannes Berg <johannes.berg@intel.com>
Currently, mac80211 always advertises that it may send
up to 64 subframes in an aggregate. This is fine, since
it's the max, but might as well be set to zero instead
since it doesn't have any information.
However, drivers might have that information, so allow
them to set a variable giving it, which will then be
used. The default of zero will be fine since to the
peer that means we don't know and it will just use its
own limit for the buffer size.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
This will apply only after Luca's patch
"mac80211: add hw configuration for max ampdu buffer size"
include/net/mac80211.h | 5 +++++
net/mac80211/agg-tx.c | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
--- wireless-testing.orig/include/net/mac80211.h 2011-01-18 13:49:49.000000000 +0100
+++ wireless-testing/include/net/mac80211.h 2011-01-18 13:50:20.000000000 +0100
@@ -1154,6 +1154,10 @@ enum ieee80211_hw_flags {
* This is only relevant if the device has restrictions on the
* number of subframes, if it relies on mac80211 to do reordering
* it shouldn't be set.
+ *
+ * @max_tx_aggregation_subframes: maximum number of subframes in an
+ * aggregate an HT driver will transmit, used by the peer as a
+ * hint to size its reorder buffer.
*/
struct ieee80211_hw {
struct ieee80211_conf conf;
@@ -1173,6 +1177,7 @@ struct ieee80211_hw {
u8 max_report_rates;
u8 max_rate_tries;
u8 max_rx_aggregation_subframes;
+ u8 max_tx_aggregation_subframes;
};
/**
--- wireless-testing.orig/net/mac80211/agg-tx.c 2011-01-18 13:49:49.000000000 +0100
+++ wireless-testing/net/mac80211/agg-tx.c 2011-01-18 13:50:20.000000000 +0100
@@ -342,7 +342,8 @@ void ieee80211_tx_ba_session_handle_star
/* send AddBA request */
ieee80211_send_addba_request(sdata, sta->sta.addr, tid,
tid_tx->dialog_token, start_seq_num,
- 0x40, tid_tx->timeout);
+ local->hw.max_tx_aggregation_subframes,
+ tid_tx->timeout);
}
int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-18 12:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-18 12:52 [PATCH] mac80211: allow advertising correct maximum aggregate size Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).