Linux wireless drivers development
 help / color / mirror / Atom feed
From: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: Kalle Valo <kvalo@adurom.com>,
	Grazvydas Ignotas <notasas@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: htc dream wl1251 and MSM_GPIO_TO_INT(29)
Date: Thu, 20 Jan 2011 13:55:15 +0100	[thread overview]
Message-ID: <1295528115.2507.9.camel@gnutoo-laptop> (raw)
In-Reply-To: <20110117150853.GC20703@hash.localnet>

> > fail_irq:
> >         printk("trout wifi GPIO failed\n");
> >         gpio_free(TROUT_WIFI_IRQ_GPIO);
> 
> But you always free a gpio here, shouldn't there be a return in there
> before the fail_irq label?
I forgot the return, I wrote/copied(from omap3-pandora ) the code when I
was tired,I shouldn't write code when I'm that tired.

> also make sure you still have the dummy msm_wifi platform device too,
yes I have it

>  and
> that the msm_wifi driver is getting a struct wifi_platform_data.
it seem to get it

> Unfortunately, I don't know of an easy way to debug livelocks due to
> interrupt storms other than by disabling everything and then enabling one
> thing at a time until it breaks again.
> 
> It's obviously going to be a lot of work, but if you can manage to get
> a current kernel booting on your hardware and dump the msm_wifi module,
> that would be the ideal approach.
I've an old linux-next kernel booting but with no way to control the
phone, fortunately the gadget driver was merged in linux-next recently.
I'll try to resolve some compilation issues and to make it work first.

Denis.


      reply	other threads:[~2011-01-20 12:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 23:33 htc dream wl1251 and MSM_GPIO_TO_INT(29) Denis 'GNUtoo' Carikli
2011-01-17 15:08 ` Bob Copeland
2011-01-20 12:55   ` Denis 'GNUtoo' Carikli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295528115.2507.9.camel@gnutoo-laptop \
    --to=gnutoo@no-log.org \
    --cc=kvalo@adurom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@bobcopeland.com \
    --cc=notasas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox