linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/3] mac80211: Support scanning only current active channel.
Date: Thu, 20 Jan 2011 18:39:03 +0100	[thread overview]
Message-ID: <1295545143.3693.44.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1295544750-6704-2-git-send-email-greearb@candelatech.com>

On Thu, 2011-01-20 at 09:32 -0800, greearb@candelatech.com wrote:

> -	ieee80211_offchannel_stop_beaconing(local);
> +	if (local->ops->sw_scan_start_cur &&
> +	    local->scan_req->n_channels == 1 &&
> +	    local->scan_req->channels[0] == local->hw.conf.channel) {
> +		__set_bit(SCAN_ON_CUR_CHANNEL, &local->scanning);
> +		drv_sw_scan_start_cur(local, true);
> +	} else
> +		drv_sw_scan_start(local);

This doesn't seem to make much sense either -- even if we do a scan over
multiple channels we should be able to optimise the part on the current
channel (maybe put it at the beginning or end too).

johannes


  reply	other threads:[~2011-01-20 17:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 17:32 [RFC 1/3] mac80211: Support sw_scan_start_cur greearb
2011-01-20 17:32 ` [RFC 2/3] mac80211: Support scanning only current active channel greearb
2011-01-20 17:39   ` Johannes Berg [this message]
2011-01-20 18:06     ` Ben Greear
2011-01-20 18:17       ` Johannes Berg
2011-01-20 18:21         ` Ben Greear
2011-01-20 18:25           ` Johannes Berg
2011-01-20 19:14           ` Helmut Schaa
2011-01-21  4:39             ` Ben Greear
2011-01-21  5:42             ` Ben Greear
2011-01-20 17:32 ` [RFC 3/3] ath9k: Support scanning on current channel greearb
2011-01-20 17:37 ` [RFC 1/3] mac80211: Support sw_scan_start_cur Johannes Berg
2011-01-20 17:52   ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295545143.3693.44.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).