From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/3] mac80211: Support scanning only current active channel.
Date: Thu, 20 Jan 2011 19:17:19 +0100 [thread overview]
Message-ID: <1295547439.3693.46.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4D3879A6.2060909@candelatech.com>
On Thu, 2011-01-20 at 10:06 -0800, Ben Greear wrote:
> > This doesn't seem to make much sense either -- even if we do a scan over
> > multiple channels we should be able to optimise the part on the current
> > channel (maybe put it at the beginning or end too).
>
> Maybe..but user-space can specify the channels it wants to scan,
> and I assume that means what order to scan them in. I have no
> idea if changing that order would confuse some application.
No, it can't actually determine the order -- we sort them in cfg80211
anyway to de-duplicate them.
> It seems to me that it would take quite a bit of re-work of the
> mac80211 scanning logic to deal with scanning on the current
> channel w/out affecting other tx/rx packets (as my patch attempts
> to do), without setting some explicit flag before you enter
> the scan state machine.
Yeah, so maybe it needs some re-work, but I think what you're doing is a
pretty strange hack.
johannes
next prev parent reply other threads:[~2011-01-20 18:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 17:32 [RFC 1/3] mac80211: Support sw_scan_start_cur greearb
2011-01-20 17:32 ` [RFC 2/3] mac80211: Support scanning only current active channel greearb
2011-01-20 17:39 ` Johannes Berg
2011-01-20 18:06 ` Ben Greear
2011-01-20 18:17 ` Johannes Berg [this message]
2011-01-20 18:21 ` Ben Greear
2011-01-20 18:25 ` Johannes Berg
2011-01-20 19:14 ` Helmut Schaa
2011-01-21 4:39 ` Ben Greear
2011-01-21 5:42 ` Ben Greear
2011-01-20 17:32 ` [RFC 3/3] ath9k: Support scanning on current channel greearb
2011-01-20 17:37 ` [RFC 1/3] mac80211: Support sw_scan_start_cur Johannes Berg
2011-01-20 17:52 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295547439.3693.46.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).