Re: [PATCH 04/14] iwlagn: 2000 series devices support

["Guy, Wey-Yi" <wey-yi.w.guy@intel.com>]

On Sun, 2011-01-23 at 03:25 -0800, Bernhard Schmidt wrote:
> On Saturday 22 January 2011 01:06:39 Wey-Yi Guy wrote:
> > From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > 
> > Adding 2000 series devices supports, the 2000 series devices has
> > many different SKUs which includes 1x1 and 2x2 devices,also with
> > and without BT combo.
> > 
> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > [..]
> > +
> > +#define IWL_DEVICE_2030						\
> > +	.fw_name_pre = IWL2030_FW_PRE,				\
> > +	.ucode_api_max = IWL2030_UCODE_API_MAX,			\
> > +	.ucode_api_min = IWL2030_UCODE_API_MIN,			\
> > +	.eeprom_ver = EEPROM_2000_EEPROM_VERSION,		\
> > +	.eeprom_calib_ver = EEPROM_2000_TX_POWER_VERSION,	\
> > +	.ops = &iwl2030_ops,					\
> > +	.mod_params = &iwlagn_mod_params,			\
> > +	.base_params = &iwl2030_base_params,			\
> > +	.bt_params = &iwl2030_bt_params,			\
> > +	.need_dc_calib = true,					\
> > +	.need_temp_offset_calib = true,				\
> > +	.led_mode = IWL_LED_RF_STATE,				\
> > +	.adv_pm = true						\
> > +
> > +struct iwl_cfg iwl2030_2bgn_cfg = {
> > +	.name = "2000 Series 2x2 BGN/BT",
> > +	IWL_DEVICE_2000,
> > +	.ht_params = &iwl2000_ht_params,
> > +};
> > +
> > +struct iwl_cfg iwl2030_2bg_cfg = {
> > +	.name = "2000 Series 2x2 BG/BT",
> > +	IWL_DEVICE_2000,
> > +};
> 
> Shouldn't these use the IWL_DEVICE_2030 macro?
> 
good catch, thank you very much, will submit separated patch to address
it

Wey