linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: linux-wireless@vger.kernel.org, Luciano Coelho <coelho@ti.com>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH v2 0/6] Probe-resp offloading support
Date: Tue, 25 Jan 2011 11:10:41 +0100	[thread overview]
Message-ID: <1295950241.3650.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTi=cSdi_i=RBtcp_aLG92S3xdMvJEMSfVdqX=qAK@mail.gmail.com>

On Mon, 2011-01-24 at 23:21 +0200, Arik Nemtsov wrote:

> Well a wiphy flag won't do here. Probe requests may be filtered in
> some modes (AP-mode) but needed in others (p2p?).
> I think flexibility is a nice added bonus here. A FW can decide to
> handle most standard probe-requests and simply not pass them up.
> Others ("complicated" ones) it can pass up to hostapd and expect it to reply.
> 
> The current patches leave this policy in the hands of the driver/fw.

That is _very_ dangerous. If the user has older firmware that doesn't
know about WSC2, how would the user know not to configure WSC2 in
hostapd? That needs to be known to hostapd so it can verify this
situation. For P2P, we already know whether or not P2P is supported, but
that's rather vague in case there will ever be a revision of the P2P
spec with say different IEs.

Additionally, a "regular AP" (not P2P, not WSC) would still want to
reply to probe requests from WSC/P2P devices with the normal template.

IMHO it would be smarter to rework the firmware to only reply to probe
requests if the probe response is configured. Then, if WSC, P2P, or
similar technologies are in use on the interface, hostapd can simply
decide to not configure the probe response and have host-based
processing. Would that be a change you could still make?

johannes


  reply	other threads:[~2011-01-25 10:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-23 21:02 [PATCH v2 0/6] Probe-resp offloading support Arik Nemtsov
2011-01-23 21:02 ` [PATCH v2 1/6] nl80211: allow passing SSID in nl80211_set_bss Arik Nemtsov
2011-01-23 21:02 ` [PATCH v2 2/6] nl80211: Pass probe response data to drivers Arik Nemtsov
2011-01-24 11:35   ` Johannes Berg
2011-01-24 20:47     ` Arik Nemtsov
2011-01-25 10:12       ` Johannes Berg
2011-01-26  6:00         ` Arik Nemtsov
2011-01-26  8:32           ` Johannes Berg
2011-01-26 21:51             ` Arik Nemtsov
2011-01-26 21:55               ` Johannes Berg
2011-01-27 13:29               ` Johannes Berg
2011-01-30 10:34                 ` Arik Nemtsov
2011-01-30 10:44                   ` Johannes Berg
2011-01-23 21:02 ` [PATCH v2 3/6] mac80211: add SSID for AP mode with change notification Arik Nemtsov
2011-01-23 21:02 ` [PATCH v2 4/6] mac80211: Save probe response data for BSS Arik Nemtsov
2011-01-24 11:38   ` Johannes Berg
2011-01-26  5:54     ` Arik Nemtsov
2011-01-23 21:02 ` [PATCH v2 5/6] wl12xx: AP mode - support hidden SSID Arik Nemtsov
2011-01-23 21:02 ` [PATCH v2 6/6] wl12xx: configure probe-resp template according to notification Arik Nemtsov
2011-01-24  9:44 ` [PATCH v2 0/6] Probe-resp offloading support Jouni Malinen
2011-01-24 21:16   ` Arik Nemtsov
2011-01-25  9:41     ` Jouni Malinen
2011-01-26  6:08       ` Arik Nemtsov
2011-01-26  6:24         ` Arik Nemtsov
2011-01-26  9:46           ` Jouni Malinen
2011-01-24 11:41 ` Johannes Berg
2011-01-24 21:21   ` Arik Nemtsov
2011-01-25 10:10     ` Johannes Berg [this message]
2011-01-25 10:42       ` Johannes Berg
2011-01-26  6:38         ` Arik Nemtsov
2011-01-26  6:35       ` Arik Nemtsov
2011-01-26  8:44         ` Johannes Berg
2011-01-26 14:04     ` Jouni Malinen
2011-01-30 11:24       ` Arik Nemtsov
2011-01-30 18:37         ` Jouni Malinen
2011-01-30 22:19           ` Arik Nemtsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295950241.3650.3.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arik@wizery.com \
    --cc=coelho@ti.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).