Re: [PATCH v2] mac80211: Optimize scans on current operating channel.

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2011-01-21 at 10:05 -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> This should decrease un-necessary flushes, on/off channel work,
> and channel changes in cases where the only scanned channel is
> the current operating channel.
> 
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> 
> v2:  Check channels instead of flag when determining if we should
>   do a channel change in scan_completed_finish.

Can you look at work.c -- where we call
ieee80211_offchannel_stop_beaconing etc.

In this patch, you're moving the call to
ieee80211_offchannel_stop_beaconing next to
ieee80211_offchannel_stop_station in scan.c.

Therefore, you can combine those two into one function.

However, I guess it'd also be nice to also address the TODO in work.c
and move the "don't do so much if not really off-channel" logic into
that function? You must run into that when trying to associate on one
vif and the others get stopped etc. unnecessarily to do that.

johannes