From: Luciano Coelho <coelho@ti.com>
To: Arik Nemtsov <arik@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 02/10] wl12xx: AP-mode - fix race condition on sta connection
Date: Wed, 26 Jan 2011 23:28:44 +0200 [thread overview]
Message-ID: <1296077324.2302.56.camel@pimenta> (raw)
In-Reply-To: <AANLkTi=sLYCiBSjv-c1L86AJ7UtDS6+p+Pax36bLJLFb@mail.gmail.com>
On Wed, 2011-01-26 at 21:04 +0100, Arik Nemtsov wrote:
> >> @@ -238,6 +254,9 @@ static int wl1271_prepare_tx_frame(struct
> wl1271 *wl, struct sk_buff *skb,
> >> if (ret < 0)
> >> return ret;
> >>
> >> + if (wl->bss_type == BSS_TYPE_AP_BSS)
> >> + wl1271_tx_ap_update_inconnection_sta(wl, skb);
> >> +
> >> wl1271_tx_fill_hdr(wl, skb, extra, info);
> >
> > Isn't there any other place where you can put this? Doesn't it add
> too
> > much overhead if you do it for every TX frame?
>
> At this stage the STA has not been officially added yet, so this is
> just a packet. In fact it won't be added unless authenticated. When
> the STA is added its too late. If we failed to mark it in-connection,
> sometimes the FW will disconnect it.
>
> Performance wise - its just another "compare + jmp" statement
> basically (checking the packet header). Didn't see any effect on
> throughput.
No, it's not just a cmp + jmp. You actually call
wl1271_tx_ap_update_inconnection_sta() and there you dig out the header
and call ieee80211_is_auth(), so you're actually parsing the header of
every frame you transmit if you're an AP. Isn't there a way to avoid
this only when necessary?
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-01-26 21:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 5:42 [PATCH 00/10] wl12xx: AP-mode per link PSM Arik Nemtsov
2011-01-16 5:42 ` [PATCH 01/10] wl12xx: fix potential race condition with TX queue watermark Arik Nemtsov
2011-01-16 5:42 ` [PATCH 02/10] wl12xx: AP-mode - fix race condition on sta connection Arik Nemtsov
2011-01-26 14:01 ` Luciano Coelho
2011-01-26 20:04 ` Arik Nemtsov
2011-01-26 21:28 ` Luciano Coelho [this message]
2011-01-26 21:33 ` Johannes Berg
2011-01-26 21:44 ` Arik Nemtsov
2011-01-26 21:54 ` Johannes Berg
2011-01-26 22:02 ` Arik Nemtsov
2011-01-26 22:08 ` Johannes Berg
2011-01-26 22:16 ` Arik Nemtsov
2011-01-26 23:11 ` Johannes Berg
2011-01-27 0:20 ` Jouni Malinen
2011-01-27 8:21 ` Johannes Berg
2011-01-16 5:42 ` [PATCH 03/10] wl12xx: AP-mode - TX queue per link in AC Arik Nemtsov
2011-01-16 5:42 ` [PATCH 04/10] mac80211: do not calc frame duration when using HW rate-control Arik Nemtsov
2011-01-16 8:34 ` Johannes Berg
2011-01-16 5:42 ` [PATCH 05/10] wl12xx: report invalid TX rate when returning non-TX-ed skbs Arik Nemtsov
2011-01-27 9:51 ` Luciano Coelho
2011-01-27 10:33 ` Johannes Berg
2011-01-30 6:57 ` Arik Nemtsov
2011-01-16 5:42 ` [PATCH 06/10] mac80211: add HW flag for disabling auto link-PS in AP mode Arik Nemtsov
2011-01-16 8:50 ` Johannes Berg
[not found] ` <AANLkTik=WDsehr0EgW7QemfdmokvaLzg1ugASwiuCOXt@mail.gmail.com>
2011-01-16 21:53 ` Fwd: " Arik Nemtsov
2011-01-17 9:35 ` Johannes Berg
2011-01-17 22:47 ` Arik Nemtsov
2011-01-18 9:05 ` Johannes Berg
2011-01-18 19:17 ` Arik Nemtsov
2011-01-27 11:39 ` Luciano Coelho
2011-01-16 5:42 ` [PATCH 07/10] wl12xx: AP-mode - support HW based link PS monitoring Arik Nemtsov
2011-01-27 11:41 ` Luciano Coelho
2011-01-16 5:42 ` [PATCH 08/10] wl12xx: AP mode - fix bug in cleanup of wl1271_op_sta_add() Arik Nemtsov
2011-01-16 5:42 ` [PATCH 09/10] wl12xx: AP-mode - count free FW TX blocks per link Arik Nemtsov
2011-01-16 5:42 ` [PATCH 10/10] wl12xx: AP-mode - management of links in PS-mode Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296077324.2302.56.camel@pimenta \
--to=coelho@ti.com \
--cc=arik@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).