From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <coelho@ti.com>
Cc: Arik Nemtsov <arik@wizery.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 05/10] wl12xx: report invalid TX rate when returning non-TX-ed skbs
Date: Thu, 27 Jan 2011 11:33:23 +0100 [thread overview]
Message-ID: <1296124403.3622.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1296121901.5263.116.camel@pimenta>
On Thu, 2011-01-27 at 11:51 +0200, Luciano Coelho wrote:
> On Sun, 2011-01-16 at 06:42 +0100, Arik Nemtsov wrote:
> > Report a TX rate idx of -1 when returning untransmitted skbs to mac80211
> > using ieee80211_tx_status(). Otherwise mac80211 tries to use the
> > returned (essentially garbage) status.
> >
> > Signed-off-by: Arik Nemtsov <arik@wizery.com>
> > ---
>
> Is this a documented way of doing it or it just happens to work?
I think the more expected way would be to set the TX counts to 0?
johannes
next prev parent reply other threads:[~2011-01-27 10:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 5:42 [PATCH 00/10] wl12xx: AP-mode per link PSM Arik Nemtsov
2011-01-16 5:42 ` [PATCH 01/10] wl12xx: fix potential race condition with TX queue watermark Arik Nemtsov
2011-01-16 5:42 ` [PATCH 02/10] wl12xx: AP-mode - fix race condition on sta connection Arik Nemtsov
2011-01-26 14:01 ` Luciano Coelho
2011-01-26 20:04 ` Arik Nemtsov
2011-01-26 21:28 ` Luciano Coelho
2011-01-26 21:33 ` Johannes Berg
2011-01-26 21:44 ` Arik Nemtsov
2011-01-26 21:54 ` Johannes Berg
2011-01-26 22:02 ` Arik Nemtsov
2011-01-26 22:08 ` Johannes Berg
2011-01-26 22:16 ` Arik Nemtsov
2011-01-26 23:11 ` Johannes Berg
2011-01-27 0:20 ` Jouni Malinen
2011-01-27 8:21 ` Johannes Berg
2011-01-16 5:42 ` [PATCH 03/10] wl12xx: AP-mode - TX queue per link in AC Arik Nemtsov
2011-01-16 5:42 ` [PATCH 04/10] mac80211: do not calc frame duration when using HW rate-control Arik Nemtsov
2011-01-16 8:34 ` Johannes Berg
2011-01-16 5:42 ` [PATCH 05/10] wl12xx: report invalid TX rate when returning non-TX-ed skbs Arik Nemtsov
2011-01-27 9:51 ` Luciano Coelho
2011-01-27 10:33 ` Johannes Berg [this message]
2011-01-30 6:57 ` Arik Nemtsov
2011-01-16 5:42 ` [PATCH 06/10] mac80211: add HW flag for disabling auto link-PS in AP mode Arik Nemtsov
2011-01-16 8:50 ` Johannes Berg
[not found] ` <AANLkTik=WDsehr0EgW7QemfdmokvaLzg1ugASwiuCOXt@mail.gmail.com>
2011-01-16 21:53 ` Fwd: " Arik Nemtsov
2011-01-17 9:35 ` Johannes Berg
2011-01-17 22:47 ` Arik Nemtsov
2011-01-18 9:05 ` Johannes Berg
2011-01-18 19:17 ` Arik Nemtsov
2011-01-27 11:39 ` Luciano Coelho
2011-01-16 5:42 ` [PATCH 07/10] wl12xx: AP-mode - support HW based link PS monitoring Arik Nemtsov
2011-01-27 11:41 ` Luciano Coelho
2011-01-16 5:42 ` [PATCH 08/10] wl12xx: AP mode - fix bug in cleanup of wl1271_op_sta_add() Arik Nemtsov
2011-01-16 5:42 ` [PATCH 09/10] wl12xx: AP-mode - count free FW TX blocks per link Arik Nemtsov
2011-01-16 5:42 ` [PATCH 10/10] wl12xx: AP-mode - management of links in PS-mode Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296124403.3622.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).