From: wwguy <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
Date: Fri, 28 Jan 2011 08:23:37 -0800 [thread overview]
Message-ID: <1296231817.7388.18.camel@wwguy-ubuntu> (raw)
In-Reply-To: <1296229671-3041-7-git-send-email-sgruszka@redhat.com>
Stanislaw,
On Fri, 2011-01-28 at 07:47 -0800, Stanislaw Gruszka wrote:
> This option practically do not change object files size, and only add
> complication for users wanted to play with experimental firmware.
> Someone who want to use or stop to use experimental firmware can
> simply add or remove proper ucode files in /lib/firmware
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/wireless/iwlwifi/Kconfig | 6 ------
> drivers/net/wireless/iwlwifi/iwl-agn.c | 2 --
> 2 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
> index e1e3b1c..4a5c51f 100644
> --- a/drivers/net/wireless/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/iwlwifi/Kconfig
> @@ -43,12 +43,6 @@ config IWLWIFI_DEBUGFS
> is a low-impact option that allows getting insight into the
> driver's state at runtime.
>
> -config IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
> - bool "Experimental uCode support"
> - depends on IWLWIFI && IWLWIFI_DEBUG
> - ---help---
> - Enable use of experimental ucode for testing and debugging.
> -
> config IWLWIFI_DEVICE_TRACING
> bool "iwlwifi device access tracing"
> depends on IWLWIFI
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
> index eb16647..23bf006 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
> @@ -1610,11 +1610,9 @@ static int __must_check iwl_request_firmware(struct iwl_priv *priv, bool first)
> char tag[8];
>
> if (first) {
> -#ifdef CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
> priv->fw_index = UCODE_EXPERIMENTAL_INDEX;
> strcpy(tag, UCODE_EXPERIMENTAL_TAG);
> } else if (priv->fw_index == UCODE_EXPERIMENTAL_INDEX) {
> -#endif
> priv->fw_index = priv->cfg->ucode_api_max;
> sprintf(tag, "%d", priv->fw_index);
> } else {
The whole reason has it in Kconfig file is to have user not remove the
experimental uCode from /lib/firmware and not use it.
Also put it in Kconfig file, so it is easy for user to see they are
using experimental option. Agree?
Wey
next prev parent reply other threads:[~2011-01-28 16:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:47 [PATCH 1/8] iwlwifi: do not set tx power when channel is changing Stanislaw Gruszka
2011-01-28 15:47 ` [PATCH 2/8] iwl3945: set STATUS_READY before commit_rxon Stanislaw Gruszka
2011-01-28 16:04 ` wwguy
2011-01-28 15:47 ` [PATCH 3/8] iwlwifi: remove unneeded __packed Stanislaw Gruszka
2011-01-28 16:05 ` wwguy
2011-01-28 15:47 ` [PATCH 4/8] iwlwifi: introduce iwl_advanced_bt_coexist() Stanislaw Gruszka
2011-01-28 16:13 ` wwguy
2011-01-28 15:47 ` [PATCH 5/8] iwlwifi: remove unneeded disable_hw_scan check Stanislaw Gruszka
2011-01-28 16:14 ` wwguy
2011-01-28 15:47 ` [PATCH 6/8] iwl3945: do not use agn specific IWL_RATE_COUNT Stanislaw Gruszka
2011-01-28 16:20 ` wwguy
2011-01-28 16:33 ` Stanislaw Gruszka
2011-01-28 16:42 ` wwguy
2011-01-31 14:54 ` wwguy
2011-01-28 15:47 ` [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE Stanislaw Gruszka
2011-01-28 16:23 ` wwguy [this message]
2011-01-28 16:41 ` Stanislaw Gruszka
2011-01-28 23:20 ` wwguy
2011-01-31 9:46 ` Stanislaw Gruszka
2011-01-31 10:23 ` Rafał Miłecki
2011-01-31 11:29 ` Stanislaw Gruszka
2011-01-31 15:01 ` wwguy
2011-01-31 15:26 ` Stanislaw Gruszka
2011-01-31 14:57 ` wwguy
2011-01-28 15:47 ` [PATCH 8/8] iwlwifi: introduce iwl_bt_statistics Stanislaw Gruszka
2011-01-28 16:24 ` wwguy
2011-01-28 16:03 ` [PATCH 1/8] iwlwifi: do not set tx power when channel is changing wwguy
2011-01-28 16:27 ` Stanislaw Gruszka
2011-01-28 16:38 ` wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296231817.7388.18.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).