From: wwguy <wey-yi.w.guy@intel.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/8] iwl3945: do not use agn specific IWL_RATE_COUNT
Date: Fri, 28 Jan 2011 08:42:22 -0800 [thread overview]
Message-ID: <1296232942.7388.24.camel@wwguy-ubuntu> (raw)
In-Reply-To: <20110128163301.GE2452@redhat.com>
Stanislaw,
On Fri, 2011-01-28 at 08:33 -0800, Stanislaw Gruszka wrote:
> On Fri, Jan 28, 2011 at 08:20:48AM -0800, wwguy wrote:
> > > --- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.h
> > > +++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.h
> > > @@ -213,6 +213,7 @@ enum {
> > > IWL_CCK_BASIC_RATES_MASK)
> > >
> > > #define IWL_RATES_MASK ((1 << IWL_RATE_COUNT) - 1)
> > > +#define IWL_RATES_MASK_3945 ((1 << IWL_RATE_COUNT_3945) - 1)
> > >
> >
> > Why define 3945 in agn header file?
> > I understand iwl-agn-rs.h is include in iwl-dev.h, which is not the
> > right thing to do. but specify 3945 in agn header file make it even more
> > confuse.
>
> $ grep 3945 drivers/net/wireless/iwlwifi/iwl-agn-rs.h
> struct iwl3945_rate_info {
> IWL_RATE_COUNT_3945 = IWL_RATE_COUNT - 1,
> * iwl3945_rate_scale_init - Initialize the rate scale table based on
> * assoc info
> extern void iwl3945_rate_scale_init(struct ieee80211_hw *hw, s32
> sta_id);
> extern void iwl3945_rs_rate_init(struct iwl_priv *priv,
> extern int iwl3945_rate_control_register(void);
> extern void iwl3945_rate_control_unregister(void);
>
> This file contains 3945 data, I agree this is confused
> and need cleanup :)
>
we are in the process of split 3945/4965 driver from _agn_
if it is ok for you, could you wait for we done the work to see if
anything need to be clean up
Thanks
Wey
next prev parent reply other threads:[~2011-01-28 16:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:47 [PATCH 1/8] iwlwifi: do not set tx power when channel is changing Stanislaw Gruszka
2011-01-28 15:47 ` [PATCH 2/8] iwl3945: set STATUS_READY before commit_rxon Stanislaw Gruszka
2011-01-28 16:04 ` wwguy
2011-01-28 15:47 ` [PATCH 3/8] iwlwifi: remove unneeded __packed Stanislaw Gruszka
2011-01-28 16:05 ` wwguy
2011-01-28 15:47 ` [PATCH 4/8] iwlwifi: introduce iwl_advanced_bt_coexist() Stanislaw Gruszka
2011-01-28 16:13 ` wwguy
2011-01-28 15:47 ` [PATCH 5/8] iwlwifi: remove unneeded disable_hw_scan check Stanislaw Gruszka
2011-01-28 16:14 ` wwguy
2011-01-28 15:47 ` [PATCH 6/8] iwl3945: do not use agn specific IWL_RATE_COUNT Stanislaw Gruszka
2011-01-28 16:20 ` wwguy
2011-01-28 16:33 ` Stanislaw Gruszka
2011-01-28 16:42 ` wwguy [this message]
2011-01-31 14:54 ` wwguy
2011-01-28 15:47 ` [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE Stanislaw Gruszka
2011-01-28 16:23 ` wwguy
2011-01-28 16:41 ` Stanislaw Gruszka
2011-01-28 23:20 ` wwguy
2011-01-31 9:46 ` Stanislaw Gruszka
2011-01-31 10:23 ` Rafał Miłecki
2011-01-31 11:29 ` Stanislaw Gruszka
2011-01-31 15:01 ` wwguy
2011-01-31 15:26 ` Stanislaw Gruszka
2011-01-31 14:57 ` wwguy
2011-01-28 15:47 ` [PATCH 8/8] iwlwifi: introduce iwl_bt_statistics Stanislaw Gruszka
2011-01-28 16:24 ` wwguy
2011-01-28 16:03 ` [PATCH 1/8] iwlwifi: do not set tx power when channel is changing wwguy
2011-01-28 16:27 ` Stanislaw Gruszka
2011-01-28 16:38 ` wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296232942.7388.24.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).