linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC v3] mac80211:  Optimize scans on current operating channel.
Date: Mon, 31 Jan 2011 14:56:23 +0100	[thread overview]
Message-ID: <1296482183.3812.29.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4D431778.1000604@candelatech.com>


> > However -- I was thinking of something else, not data packets. While
> > scanning, all received beacons will be handed to the scan code. But if
> > the mlme code isn't told to stop looking for them, it'll still expect to
> > see the beacons.
> 
> Currently, it seems mlme timers are stopped when we start scanning,
> and then started when scanning is complete.

Ok, I wasn't quite sure about that part -- whether it happened when
going off-channel or when starting scan. If it happened while going
off-channel this would've been problematic here.

> However, I don't see any similar effort in the work_work() method
> when it goes off-channel.
> 
> Should we move the timer pause & restart logic into the offchannel_stop_vifs
> and offchannel_return methods?

Well, sort of no, and sort of yes -- both will disrupt that code in a
sense, but even scanning on the same channel will disrupt it due to the
beacon diversion, unless we copy the beacons and give them to both sides
(scan and mlme)?

johannes


  reply	other threads:[~2011-01-31 13:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 20:37 [RFC v3] mac80211: Optimize scans on current operating channel greearb
2011-01-27 13:52 ` Johannes Berg
2011-01-27 17:17   ` Ben Greear
2011-01-28 13:24     ` Johannes Berg
2011-01-28 18:47       ` Ben Greear
2011-01-27 18:33   ` Ben Greear
2011-01-28 13:20     ` Johannes Berg
2011-01-28 19:22       ` Ben Greear
2011-01-31 13:56         ` Johannes Berg [this message]
2011-01-31 17:30           ` Ben Greear
2011-01-31 17:32             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296482183.3812.29.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).