From: wwguy <wey-yi.w.guy@intel.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
Date: Mon, 31 Jan 2011 06:57:20 -0800 [thread overview]
Message-ID: <1296485840.10026.4.camel@wwguy-ubuntu> (raw)
In-Reply-To: <AANLkTinBneG0nqGFt=mnP0-ZSdLGzdxhfYpyo62WYJQA@mail.gmail.com>
Stanislaw,
On Mon, 2011-01-31 at 02:23 -0800, Rafał Miłecki wrote:
> 2011/1/31 Stanislaw Gruszka <sgruszka@redhat.com>:
> > On Fri, Jan 28, 2011 at 03:20:21PM -0800, wwguy wrote:
> >> > What is easiest and less time consuming:
> >> >
> >> > this:
> >> >
> >> > $ mv /lib/firmware/iwlwifi-5000-exp.ucode /lib/firmware/iwlwifi-5000-exp.ucode.not_use
> >> >
> >> > or this:
> >> >
> >> > $ make menuconfig
> >> > navigate to find option and edit it
> >> > $ make modules
> >> > $ make modules_install
> >> >
> >> > ?
> >> >
> >> > > Also put it in Kconfig file, so it is easy for user to see they are
> >> > > using experimental option. Agree?
> >> >
> >> > Not really. I believe someone who download a tarball, unpack it and copy
> >> > files to /lib/firmware is pretty much aware what he/she is doing.
> >> >
> >> Agree whoever download the tarball know what he/she is doing, but I am
> >> not fully agree the driver always use experimental uCode if it is in the
> >> firmware directory
> >
> > I do not understand what for you need that, but ok, I can live with it.
> >
> > John, please skip this patch.
>
> Maybe make it module parameter? Like use_experimental_fw, default to 0?
>
I think module parameter is better idea, if you agree, and I will ack
Thanks
Wey
next prev parent reply other threads:[~2011-01-31 14:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:47 [PATCH 1/8] iwlwifi: do not set tx power when channel is changing Stanislaw Gruszka
2011-01-28 15:47 ` [PATCH 2/8] iwl3945: set STATUS_READY before commit_rxon Stanislaw Gruszka
2011-01-28 16:04 ` wwguy
2011-01-28 15:47 ` [PATCH 3/8] iwlwifi: remove unneeded __packed Stanislaw Gruszka
2011-01-28 16:05 ` wwguy
2011-01-28 15:47 ` [PATCH 4/8] iwlwifi: introduce iwl_advanced_bt_coexist() Stanislaw Gruszka
2011-01-28 16:13 ` wwguy
2011-01-28 15:47 ` [PATCH 5/8] iwlwifi: remove unneeded disable_hw_scan check Stanislaw Gruszka
2011-01-28 16:14 ` wwguy
2011-01-28 15:47 ` [PATCH 6/8] iwl3945: do not use agn specific IWL_RATE_COUNT Stanislaw Gruszka
2011-01-28 16:20 ` wwguy
2011-01-28 16:33 ` Stanislaw Gruszka
2011-01-28 16:42 ` wwguy
2011-01-31 14:54 ` wwguy
2011-01-28 15:47 ` [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE Stanislaw Gruszka
2011-01-28 16:23 ` wwguy
2011-01-28 16:41 ` Stanislaw Gruszka
2011-01-28 23:20 ` wwguy
2011-01-31 9:46 ` Stanislaw Gruszka
2011-01-31 10:23 ` Rafał Miłecki
2011-01-31 11:29 ` Stanislaw Gruszka
2011-01-31 15:01 ` wwguy
2011-01-31 15:26 ` Stanislaw Gruszka
2011-01-31 14:57 ` wwguy [this message]
2011-01-28 15:47 ` [PATCH 8/8] iwlwifi: introduce iwl_bt_statistics Stanislaw Gruszka
2011-01-28 16:24 ` wwguy
2011-01-28 16:03 ` [PATCH 1/8] iwlwifi: do not set tx power when channel is changing wwguy
2011-01-28 16:27 ` Stanislaw Gruszka
2011-01-28 16:38 ` wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296485840.10026.4.camel@wwguy-ubuntu \
--to=wey-yi.w.guy@intel.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).