linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org
Subject: Re: [RFC] rt2x00: Add autowakeup timer for receiving beacons while in powersave mode
Date: Mon, 31 Jan 2011 16:22:42 +0100	[thread overview]
Message-ID: <1296487362.3812.33.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201101311600.39486.IvDoorn@gmail.com>

On Mon, 2011-01-31 at 16:00 +0100, Ivo van Doorn wrote:
> Add a delayed work structure which can be used to wakeup the device
> just before a beacon from the AP is expected. This then allows the device
> to receive the beacon, check if there are pending broadcast or multicast frames.
> 
> TODO: Split out mac80211 changes into a separate patch. We also need
> to know if we need this check in mac80211 or in the driver. Personally I think the
> check belongs in mac80211, but at this time that work has been deferred to the drivers.
> However this means that a lot of logic is needed in the driver to check if the correct IE
> is available, and then check the value, while mac80211 will obtains that exact IE anyway
> during RX processing anyway...

Hmm. I've always said that there's no efficient way to do this in
mac80211. If you do it close to the beacon, unexpected latency means
that we miss -- this can be severe if something else is happening in the
system, especially with USB devices. If you do it early before the
beacon, then you don't save much power. As a consequence, I don't really
like this in mac80211.

However, it seems you only added "stay awake after beacon" code to
mac80211 that checks the TIM. Assuming the device actually stays awake
for multicast traffic by itself that seems like an option, though I
wouldn't wait for the next beacon before going to sleep again --
wouldn't that happen with the timer anyway?

johannes


  reply	other threads:[~2011-01-31 15:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 15:00 [RFC] rt2x00: Add autowakeup timer for receiving beacons while in powersave mode Ivo van Doorn
2011-01-31 15:22 ` Johannes Berg [this message]
2011-01-31 15:38   ` Ivo Van Doorn
2011-01-31 15:54     ` [rt2x00-users] " Johannes Stezenbach
2011-01-31 18:17 ` Johannes Stezenbach
2011-01-31 19:00   ` Ivo Van Doorn
2011-01-31 21:05     ` Johannes Stezenbach
2011-02-02 17:42 ` Kalle Valo
2011-02-02 19:09   ` Ivo Van Doorn
2011-02-10  5:24     ` RA-Jay Hung
2011-02-14 10:14       ` Ivo Van Doorn
2011-02-14 10:25         ` Johannes Berg
2011-02-02 21:29   ` Johannes Stezenbach
2011-02-07 23:33     ` [rt2x00-users] " Aleksandar Milivojevic
2011-02-08  8:48       ` Kalle Valo
2011-02-08 19:11         ` Aleksandar Milivojevic
2011-02-09 12:17           ` Kalle Valo
2011-02-09 14:31           ` Johannes Stezenbach
2011-02-08  8:27     ` Kalle Valo
2011-02-08 20:09       ` Johannes Stezenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296487362.3812.33.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).