From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Recalculate channel-type on iface removal.
Date: Mon, 31 Jan 2011 20:12:16 +0100 [thread overview]
Message-ID: <1296501136.3812.45.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4D4707CD.60903@candelatech.com>
On Mon, 2011-01-31 at 11:04 -0800, Ben Greear wrote:
> >> The set-channel-type logic will complain, and I imagine the interfaces
> >> will bounce around and attempt to re-associate, but I think it can
> >> get into the mixed state.
> >
> > I think we should try to avoid that.
>
> Ok. I haven't actually tested that case yet. It's possible
> that we can't actually get in that case..but I haven't found
> anything that prevents it while reading code. Assuming there is a problem,
> what would be the preferred fix? Maybe force to NO_HT if an interface
> tries to associate with HT40+/- mis-match?
I think ieee80211_enable_ht() checks this?
> Do you want me to repost this patch without the WARN_ON_ONCE
> changes?
For now, I think that'd be nicer. I suspect it doesn't actually matter
since the above means we can't get into that situation. Still we may
want WARN_ON_ONCE to prevent being flooded, but I guess it should be a
separate patch?
johannes
prev parent reply other threads:[~2011-01-31 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 18:37 [PATCH] mac80211: Recalculate channel-type on iface removal greearb
2011-01-31 18:44 ` Johannes Berg
2011-01-31 18:48 ` Ben Greear
2011-01-31 18:57 ` Johannes Berg
2011-01-31 19:04 ` Ben Greear
2011-01-31 19:12 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296501136.3812.45.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).