From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:5886 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754097Ab1BIRFr (ORCPT ); Wed, 9 Feb 2011 12:05:47 -0500 Subject: Re: [PATCH 2/5] iwlwifi: cleanup {iwl,iwl3945}_good_plcp_health From: wwguy To: Stanislaw Gruszka Cc: Intel Linux Wireless , "linux-wireless@vger.kernel.org" In-Reply-To: <20110209062412.GA2184@redhat.com> References: <1297153919-18766-1-git-send-email-sgruszka@redhat.com> <1297153919-18766-2-git-send-email-sgruszka@redhat.com> <1297178645.20613.28.camel@wwguy-ubuntu> <20110209062412.GA2184@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 09 Feb 2011 09:03:56 -0800 Message-ID: <1297271036.20613.62.camel@wwguy-ubuntu> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2011-02-08 at 22:24 -0800, Stanislaw Gruszka wrote: > Hi Wey > > On Tue, Feb 08, 2011 at 07:24:05AM -0800, wwguy wrote: > > On Tue, 2011-02-08 at 00:31 -0800, Stanislaw Gruszka wrote: > > > Make plcp health code human readable. > > > > > > Signed-off-by: Stanislaw Gruszka > > > --- > > > drivers/net/wireless/iwlwifi/iwl-3945.c | 83 +++++++----------- > > > drivers/net/wireless/iwlwifi/iwl-agn-rx.c | 122 +++++++++++---------------- > > > drivers/net/wireless/iwlwifi/iwl-commands.h | 1 + > > > 3 files changed, 80 insertions(+), 126 deletions(-) > > > > > > > Thanks for the clean up, now is much easier to read. > > > > Now we are very close to release the split driver, here you change both > > agn and 3945, not sure what is the easier approach will be? push the > > patch now, or wait for the driver split finish, then push the patch > > after that. > > I will repost my patches on top of your changes, > hope they'll go to 2.6.39 ? > yes, we are targeting 2.6.39, but if there is any delay, I will let you know. Don't want to hold off your patch if we delay. We should know by the end of this week Wey