From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: implicit band switch or not
Date: Mon, 14 Feb 2011 11:05:31 +0100 [thread overview]
Message-ID: <1297677931.3785.8.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <op.vqmzowhl3ri7v4@arend-laptop>
On Wed, 2011-02-09 at 13:59 +0100, Arend van Spriel wrote:
> Hi Johannes,
>
> With our mac80211-based driver I was associated with 5GHz AP and ran into
> an assert. Investigating this I found that a software scan was initiated
> and our driver got a probe request from mac80211 to be transmitted.
> However, it turned out that the transmit rate was a 2GHz rate and our
> driver was still configured to 5GHz band. The ieee80211_tx_info also
> contained the band and indeed that was for 2GHz. Given the comment for the
> band attribute I am wondering whether we should a band switch implicitly
> or not:
>
> * @band: the band to transmit on (use for checking for races)
>
> Any suggestions? Are we have a race condition here?
Yes, there are race conditions here -- do you implement flush? If yes,
it might be interesting to hook up the tx function to tracing (in
mac80211) and analyse the race in more detail via tracing.
johannes
prev parent reply other threads:[~2011-02-14 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 12:59 implicit band switch or not Arend van Spriel
2011-02-09 14:22 ` Ben Greear
2011-02-09 14:48 ` Arend van Spriel
2011-02-09 17:10 ` Ben Greear
2011-02-14 10:05 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297677931.3785.8.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).