From: Johannes Berg <johannes@sipsolutions.net>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211: interface update
Date: Mon, 14 Feb 2011 11:20:58 +0100 [thread overview]
Message-ID: <1297678858.3785.20.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1297252905-29739-2-git-send-email-zefir.kurtisi@neratec.com>
I'm thinking this is [RFC] really?
> @@ -1076,6 +1078,10 @@ enum nl80211_attrs {
>
> /* add attributes here, update the policy in nl80211.c */
>
> + NL80211_DFSEVENT_ATTR_FREQ,
> + NL80211_DFSEVENT_ATTR_TS,
> + NL80211_DFSEVENT_ATTR_WIDTH,
I think it would be preferable to create a new DFS_EVENT attribute (also
note that all attributse should be prefixed by NL80211_ATTR_) and then
nest data into it.
However, why is the TS/width data needed at all?
johannes
next prev parent reply other threads:[~2011-02-14 10:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 12:01 [RFC] DFS userspace handler Zefir Kurtisi
2011-02-09 12:01 ` [PATCH 1/2] nl80211: interface update Zefir Kurtisi
2011-02-09 14:31 ` John W. Linville
2011-02-09 15:32 ` Zefir Kurtisi
2011-02-14 10:20 ` Johannes Berg [this message]
2011-02-14 15:54 ` Zefir Kurtisi
2011-02-09 12:01 ` [PATCH 2/2] ath9k: pulse detection Zefir Kurtisi
2011-02-09 15:15 ` Vasanth Thiagarajan
2011-02-09 15:30 ` Zefir Kurtisi
2011-02-09 12:01 ` [PATCH 1/3] hostapd: simple pattern detector Zefir Kurtisi
2011-02-09 12:01 ` [PATCH 2/3] hostapd: nl80211 interface Zefir Kurtisi
2011-02-09 12:01 ` [PATCH 3/3] hostapd: integrate DFS detection Zefir Kurtisi
2011-02-09 14:34 ` [RFC] DFS userspace handler John W. Linville
2011-02-09 15:35 ` Chaoxing Lin
2011-02-09 15:50 ` Zefir Kurtisi
2011-02-09 16:09 ` Chaoxing Lin
2011-02-09 16:30 ` John W. Linville
2011-02-09 17:09 ` Chaoxing Lin
2011-02-09 17:50 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297678858.3785.20.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).