Re: [PATCH 1/1] iwl3945: iwl3945_good_plcp_health might not used

[wwguy <wey-yi.w.guy@intel.com>]

On Mon, 2011-02-14 at 01:06 -0800, Stanislaw Gruszka wrote:
> Hi Wey
> 
> On Fri, Feb 11, 2011 at 07:22:49AM -0800, wwguy wrote:
> > On Fri, 2011-02-11 at 06:49 -0800, Stanislaw Gruszka wrote:
> > > On Thu, Feb 10, 2011 at 08:16:33AM -0800, Wey-Yi Guy wrote:
> > > > remove plcp check for 3945, mark the function __maybe_unused
> > > > 
> > > > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > > > Cc: <stable@kernel.org> # .35+: c91d015: iwl3945: remove plcp check
> > > > Cc: stable@kernel.org  # 2.6.35+
> > > > ---
> > > >  drivers/net/wireless/iwlwifi/iwl-3945.c |    2 +-
> > > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > > 
> > I see your point, but I also think it des not mean other driver doing
> > bad, so we can do it too. do you agree?
> 
> Fully agree :-)
> 
> > I like to see the iwlwifi driver
> > as clean as possible (do our best :-))
> > hope it is ok for you.
> 
> Of course it is. But I do not complained about fixing warning, but about
> posting it to -stable. Thats clearly not -stable fix as stated in
> Documentation/stable_kernel_rules.txt .
> 
> I should have add that __maybe_unused to my patch, but I didn't.
> What we could do now is fix warning in upstream and live with it
> in -stable .
> 
yeap, I agree with you , no need to go to _stable

Wey