From: Johannes Berg <johannes@sipsolutions.net>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/1] iwl3945: iwl3945_good_plcp_health might not used
Date: Mon, 14 Feb 2011 16:28:54 +0100 [thread overview]
Message-ID: <1297697334.3953.7.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1297697139.4723.4.camel@wwguy-ubuntu>
On Mon, 2011-02-14 at 07:25 -0800, wwguy wrote:
> On Mon, 2011-02-14 at 01:55 -0800, Johannes Berg wrote:
> > On Thu, 2011-02-10 at 08:16 -0800, Wey-Yi Guy wrote:
> > > remove plcp check for 3945, mark the function __maybe_unused
> >
> > Why not remove the function instead?
> >
> I guess we can remove it in legacy driver
But it's a 3945 specific function, and never used, so ...??
johannes
next prev parent reply other threads:[~2011-02-14 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 16:16 [PATCH 1/1] iwl3945: iwl3945_good_plcp_health might not used Wey-Yi Guy
2011-02-11 14:49 ` Stanislaw Gruszka
2011-02-11 15:22 ` wwguy
2011-02-14 9:06 ` Stanislaw Gruszka
2011-02-14 15:27 ` wwguy
2011-02-14 9:55 ` Johannes Berg
2011-02-14 15:25 ` wwguy
2011-02-14 15:28 ` Johannes Berg [this message]
2011-02-14 15:48 ` wwguy
2011-02-14 15:54 ` Johannes Berg
2011-02-14 15:57 ` wwguy
2011-02-14 20:10 ` John W. Linville
2011-02-14 20:31 ` wwguy
2011-02-14 21:05 ` John W. Linville
2011-02-14 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297697334.3953.7.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).