From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com ([134.134.136.20]:42892 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755739Ab1BNPt5 (ORCPT ); Mon, 14 Feb 2011 10:49:57 -0500 Subject: Re: [PATCH 1/1] iwl3945: iwl3945_good_plcp_health might not used From: wwguy To: Johannes Berg Cc: "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" In-Reply-To: <1297697334.3953.7.camel@jlt3.sipsolutions.net> References: <1297354593-22897-1-git-send-email-wey-yi.w.guy@intel.com> <1297677349.3785.3.camel@jlt3.sipsolutions.net> <1297697139.4723.4.camel@wwguy-ubuntu> <1297697334.3953.7.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 14 Feb 2011 07:48:06 -0800 Message-ID: <1297698486.4723.15.camel@wwguy-ubuntu> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2011-02-14 at 07:28 -0800, Johannes Berg wrote: > On Mon, 2011-02-14 at 07:25 -0800, wwguy wrote: > > On Mon, 2011-02-14 at 01:55 -0800, Johannes Berg wrote: > > > On Thu, 2011-02-10 at 08:16 -0800, Wey-Yi Guy wrote: > > > > remove plcp check for 3945, mark the function __maybe_unused > > > > > > Why not remove the function instead? > > > > > I guess we can remove it in legacy driver > > But it's a 3945 specific function, and never used, so ...?? > I mean we should remove this function in legacy driver after driver split Wey >