From: "Michael Büsch" <mb@bu3sch.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
b43-dev <b43-dev@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ssb: Make ssb_wait_bit multi-bit safe
Date: Tue, 15 Feb 2011 00:59:29 +0100 [thread overview]
Message-ID: <1297727969.5683.21.camel@maggie> (raw)
In-Reply-To: <AANLkTimjkFJrWpubECRRNybmvYdcAh3UUbMOa0iv166g@mail.gmail.com> (sfid-20110215_004511_709733_4814F921)
On Tue, 2011-02-15 at 00:44 +0100, Rafał Miłecki wrote:
> 2011/2/15 Michael Büsch <mb@bu3sch.de>:
> > ssb_wait_bit was designed for only one-bit bitmasks.
> > People start using it for multi-bit bitmasks. Make the "set" case
> > is safe for this. The "unset" case is already safe.
>
> Thanks :)
This should not change the behavior of your patch, though,
as you only add an "unset" case, which was already correct.
So this doesn't fix an actual bug but rather hardens the code
for future use.
--
Greetings Michael.
next prev parent reply other threads:[~2011-02-14 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 23:21 [PATCH] ssb: Make ssb_wait_bit multi-bit safe Michael Büsch
2011-02-14 23:44 ` Rafał Miłecki
2011-02-14 23:59 ` Michael Büsch [this message]
2011-02-15 0:04 ` Rafał Miłecki
2011-02-15 0:03 ` Gábor Stefanik
2011-02-15 0:20 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297727969.5683.21.camel@maggie \
--to=mb@bu3sch.de \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).