* ath9k htc bug?
@ 2011-02-15 12:35 Johannes Berg
2011-02-15 13:27 ` Sujith
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2011-02-15 12:35 UTC (permalink / raw)
To: linux-wireless; +Cc: Sujith
This code in ath9k_ht_tx looks buggy:
if (padsize && skb->len > padpos) {
if (skb_headroom(skb) < padsize)
return -1;
skb_push(skb, padsize);
memmove(skb->data, skb->data + padsize, padpos);
}
-1 isn't a valid netdev tx status code -- I think this should just be
"goto fail_tx;" instead?
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
* ath9k htc bug?
2011-02-15 12:35 ath9k htc bug? Johannes Berg
@ 2011-02-15 13:27 ` Sujith
0 siblings, 0 replies; 2+ messages in thread
From: Sujith @ 2011-02-15 13:27 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
Johannes Berg wrote:
> This code in ath9k_ht_tx looks buggy:
>
> if (padsize && skb->len > padpos) {
> if (skb_headroom(skb) < padsize)
> return -1;
> skb_push(skb, padsize);
> memmove(skb->data, skb->data + padsize, padpos);
> }
>
> -1 isn't a valid netdev tx status code -- I think this should just be
> "goto fail_tx;" instead?
Yep, I have a fix lined up in my pending queue doing exactly that. :)
Sujith
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-15 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-15 12:35 ath9k htc bug? Johannes Berg
2011-02-15 13:27 ` Sujith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).