From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Fix a race on enabling power save.
Date: Wed, 16 Feb 2011 12:11:28 +0100 [thread overview]
Message-ID: <1297854688.3736.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <AANLkTin3V5Ck6vtJshcjG9KxrK8pX3vOYhKGfVjqupxw@mail.gmail.com>
On Wed, 2011-02-16 at 15:01 +0530, Vivek Natarajan wrote:
> >> And this is how I understand this:
> >> stop queues, then send nullfunc, then do a flush to get the status and
> >> wake queues again irrespective of acked or not(but set the ACK_STATUS
> >> correspondingly). If tx() routine of nullfunc fails, then also wake
> >> the queues.
> >
> > Yes, but since the flush is there, the latter (tx fails, ...) won't be
> > needed.
>
> If queues are stopped before sending nullfunc, it is added in the
> pending frames queue and the flush after nullfunc is ineffective. So,
> is it okay to bypass this queue_stop check with REASON_PS if it is a
> nullfunc frame? Any more ideas will be helpful.
Ah, but I wasn't thinking of stopping the device queues, just the sdata
queues, and the nullfunc doesn't go across those.
johannes
next prev parent reply other threads:[~2011-02-16 11:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 12:25 [PATCH v2] mac80211: Fix a race on enabling power save Vivek Natarajan
2011-02-04 13:05 ` Johannes Berg
2011-02-04 13:07 ` Johannes Berg
2011-02-04 13:08 ` Johannes Berg
2011-02-04 13:12 ` Johannes Berg
2011-02-04 13:28 ` Vivek Natarajan
2011-02-04 14:08 ` Johannes Berg
2011-02-04 14:28 ` Vivek Natarajan
2011-02-15 14:28 ` Vivek Natarajan
2011-02-08 10:13 ` Vivek Natarajan
2011-02-15 12:44 ` Johannes Berg
2011-02-15 14:04 ` Vivek Natarajan
2011-02-15 14:09 ` Johannes Berg
2011-02-15 14:41 ` Vivek Natarajan
2011-02-16 9:31 ` Vivek Natarajan
2011-02-16 11:11 ` Johannes Berg [this message]
2011-02-16 12:28 ` Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297854688.3736.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).