From: Johannes Berg <johannes@sipsolutions.net>
To: Vivek Natarajan <vnatarajan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Clear PS related flag on disabling power save.
Date: Fri, 18 Feb 2011 12:05:22 +0100 [thread overview]
Message-ID: <1298027122.3772.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1298018905-6984-1-git-send-email-vnatarajan@atheros.com>
On Fri, 2011-02-18 at 14:18 +0530, Vivek Natarajan wrote:
> Clear IEEE80211_STA_NULLFUNC_ACKED flag on disabling power
> save. Without this fix, there is a chance of setting CONF_PS
> before sending nullfunc frame.
>
> Signed-off-by: Vivek Natarajan <vnatarajan@atheros.com>
> ieee80211_queue_work(&local->hw,
> &local->dynamic_ps_disable_work);
> + ifmgd->flags &= ~IEEE80211_STA_NULLFUNC_ACKED;
Shouldn't those be the other way around, just to make reading easier?
johannes
prev parent reply other threads:[~2011-02-18 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 8:48 [PATCH 2/2] mac80211: Clear PS related flag on disabling power save Vivek Natarajan
2011-02-18 11:05 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298027122.3772.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).