Re: [RFC] AI support (2/14 ssb helpers)

["Michael Büsch" <mb@bu3sch.de>]

On Sat, 2011-02-19 at 01:15 +0200, George Kashperko wrote: 
> > On Fri, 2011-02-18 at 00:08 +0200, George Kashperko wrote: 
> > > 	const struct ssb_bus_ops *ops;
> > > +	const struct ssb_bus_helpers *helpers;
> > 
> > Uhm, well. "helpers"... . Seems like a pretty generic term.
> > 
> > I think this is still violating abstraction layering. Not as much
> > as your previous attempt, but still...
> > 
> > You're putting the ops structure that is supposed to abstract
> > the ssb bus into the ssb_device data structure. That should ring a bell.
> > 
> Reconsidered it already while arranging patches for Openwrt (the reason
> helpers were in device struct was to speedup access but these aint
> called often therefore they are in ssb_bus now). Also moved

I should probably note that in my opinion ssb_bus is not the right place
to put ops that are supposed to abstract the SSB bus, too. ;)
_No_ SSB structure is the right place to put an ops pointer that is
supposed to abstract the SSB bus.

-- 
Greetings Michael.