From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
Frank Huang <frankh@marvell.com>, Greg KH <greg@kroah.com>,
"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH 00/31] wireless: Marvell mwifiex driver for SD8787
Date: Wed, 23 Feb 2011 09:23:53 +0100 [thread overview]
Message-ID: <1298449433.3747.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F704307F50C44E4@SC-VEXCH1.marvell.com>
On Tue, 2011-02-22 at 19:37 -0800, Bing Zhao wrote:
> Is it OK if I change PRINTM (debugging printk) to something like IWL_DEBUG_?
>
> <drivers/net/wireless/iwlwifi/iwl-debug.h>
> ......
> #define IWL_DEBUG_INFO(p, f, a...) IWL_DEBUG(p, IWL_DL_INFO, f, ## a)
> #define IWL_DEBUG_MAC80211(p, f, a...) IWL_DEBUG(p, IWL_DL_MAC80211, f, ## a)
> #define IWL_DEBUG_MACDUMP(p, f, a...) IWL_DEBUG(p, IWL_DL_MACDUMP, f, ## a)
> #define IWL_DEBUG_TEMP(p, f, a...) IWL_DEBUG(p, IWL_DL_TEMP, f, ## a)
> #define IWL_DEBUG_SCAN(p, f, a...) IWL_DEBUG(p, IWL_DL_SCAN, f, ## a)
> #define IWL_DEBUG_RX(p, f, a...) IWL_DEBUG(p, IWL_DL_RX, f, ## a)
> #define IWL_DEBUG_TX(p, f, a...) IWL_DEBUG(p, IWL_DL_TX, f, ## a)
> #define IWL_DEBUG_ISR(p, f, a...) IWL_DEBUG(p, IWL_DL_ISR, f, ## a)
> ......
>
> Or, you want me to remove PRINTM stuff completely?
Yeah, I know that's there in iwlwifi too ... I don't like it, but I
couldn't yet get it removed or replaced by newer infrastructure (which
didn't exist when this was written). Can I convince you to at least look
at pr_debug based things?
johannes
next prev parent reply other threads:[~2011-02-23 8:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 1:31 [PATCH 00/31] wireless: Marvell mwifiex driver for SD8787 Bing Zhao
2010-12-02 19:33 ` John W. Linville
2010-12-02 19:58 ` Johannes Berg
2010-12-03 12:53 ` Johannes Berg
2010-12-03 15:06 ` Greg KH
[not found] ` <477F20668A386D41ADCC57781B1F704307D59F9D6D@SC-VEXCH1.marvell.com>
[not found] ` <77956EDC1B917843AC9B7965A3BD78B058FEF48E24@SC-VEXCH2.marvell.com>
2010-12-03 18:39 ` Johannes Berg
2010-12-03 19:11 ` John W. Linville
2010-12-03 21:17 ` [PATCH 0/3] mwifiex: remove some stuff John W. Linville
2010-12-03 22:22 ` Bing Zhao
2010-12-04 0:34 ` Bing Zhao
2010-12-06 19:14 ` Bing Zhao
2010-12-03 21:17 ` [PATCH 1/3] mwifiex: remove uAP functionality John W. Linville
2010-12-03 21:17 ` [PATCH 2/3] mwifiex: remove NETLINK_MARVELL and associate madness John W. Linville
2010-12-03 21:17 ` [PATCH 3/3] mwifiex: remove questionable wireless_send_event stuff John W. Linville
2010-12-04 0:59 ` [PATCH 00/31] wireless: Marvell mwifiex driver for SD8787 Bing Zhao
2010-12-03 22:15 ` Bing Zhao
2011-02-23 3:37 ` Bing Zhao
2011-02-23 8:23 ` Johannes Berg [this message]
2011-02-23 19:26 ` Bing Zhao
2011-03-11 4:04 ` Bing Zhao
2011-03-11 8:45 ` Johannes Berg
2011-03-11 14:12 ` John W. Linville
2011-03-11 18:31 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298449433.3747.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=dkiran@marvell.com \
--cc=dwmw2@infradead.org \
--cc=frankh@marvell.com \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).