From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Alina Friedrichsen <x-alina@gmx.net>, Bruno Randolf <br1@einfach.org>
Subject: IBSS merge
Date: Wed, 23 Feb 2011 12:35:13 +0100 [thread overview]
Message-ID: <1298460913.4122.2.camel@jlt3.sipsolutions.net> (raw)
Hi,
I'm confused about our IBSS merge code.
ieee80211_rx_bss_info:
...
/* same BSSID */
if (memcmp(cbss->bssid, sdata->u.ibss.bssid, ETH_ALEN) == 0)
goto put_bss;
...
/* give slow hardware some time to do the TSF sync */
if (rx_timestamp < IEEE80211_IBSS_MERGE_DELAY)
goto put_bss;
...
Both of this was added by Alina, but why did the patch adding the first
part not remove the second part again? If we suddenly need to adopt a
new BSSID due to higher TSF why wait for the HW to sync first?
It seems the latter was a workaround for syncing over and over again
when the HW hadn't caught up yet, but that doesn't seem worthwhile any
more since we no longer re-sync with the same BSSID?
johannes
next reply other threads:[~2011-02-23 11:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 11:35 Johannes Berg [this message]
2011-02-23 11:47 ` IBSS merge Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298460913.4122.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=br1@einfach.org \
--cc=linux-wireless@vger.kernel.org \
--cc=x-alina@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).