* [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS
@ 2011-02-02 9:20 Eliad Peller
2011-02-02 10:16 ` Johannes Berg
2011-02-23 13:52 ` Luciano Coelho
0 siblings, 2 replies; 3+ messages in thread
From: Eliad Peller @ 2011-02-02 9:20 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless
The wl12xx fw supports ack status reporting for tx frames, so
add the IEEE80211_HW_REPORTS_TX_ACK_STATUS flag to our supported
features.
Since we do the rate control in the fw, we'll probably want
to adjust the STA_LOST_PKT_THRESHOLD heuristics in the future, to
account for retransmissions as well.
Signed-off-by: Eliad Peller <eliad@wizery.com>
---
drivers/net/wireless/wl12xx/main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index dfab21e..fa05149 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -3215,7 +3215,8 @@ int wl1271_init_ieee80211(struct wl1271 *wl)
IEEE80211_HW_SUPPORTS_UAPSD |
IEEE80211_HW_HAS_RATE_CONTROL |
IEEE80211_HW_CONNECTION_MONITOR |
- IEEE80211_HW_SUPPORTS_CQM_RSSI;
+ IEEE80211_HW_SUPPORTS_CQM_RSSI |
+ IEEE80211_HW_REPORTS_TX_ACK_STATUS;
wl->hw->wiphy->cipher_suites = cipher_suites;
wl->hw->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS
2011-02-02 9:20 [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS Eliad Peller
@ 2011-02-02 10:16 ` Johannes Berg
2011-02-23 13:52 ` Luciano Coelho
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2011-02-02 10:16 UTC (permalink / raw)
To: Eliad Peller; +Cc: Luciano Coelho, linux-wireless
On Wed, 2011-02-02 at 11:20 +0200, Eliad Peller wrote:
> The wl12xx fw supports ack status reporting for tx frames, so
> add the IEEE80211_HW_REPORTS_TX_ACK_STATUS flag to our supported
> features.
>
> Since we do the rate control in the fw, we'll probably want
> to adjust the STA_LOST_PKT_THRESHOLD heuristics in the future, to
> account for retransmissions as well.
I agree, they're very rough -- they don't even account for
retransmissions now. I also think some timing should be taken into
account as TCP will quickly stop sending packets.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS
2011-02-02 9:20 [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS Eliad Peller
2011-02-02 10:16 ` Johannes Berg
@ 2011-02-23 13:52 ` Luciano Coelho
1 sibling, 0 replies; 3+ messages in thread
From: Luciano Coelho @ 2011-02-23 13:52 UTC (permalink / raw)
To: Eliad Peller; +Cc: linux-wireless
On Wed, 2011-02-02 at 11:20 +0200, Eliad Peller wrote:
> The wl12xx fw supports ack status reporting for tx frames, so
> add the IEEE80211_HW_REPORTS_TX_ACK_STATUS flag to our supported
> features.
>
> Since we do the rate control in the fw, we'll probably want
> to adjust the STA_LOST_PKT_THRESHOLD heuristics in the future, to
> account for retransmissions as well.
>
> Signed-off-by: Eliad Peller <eliad@wizery.com>
> ---
Applied, thank you!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-23 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-02 9:20 [PATCH] wl12xx: declare support for IEEE80211_HW_REPORTS_TX_ACK_STATUS Eliad Peller
2011-02-02 10:16 ` Johannes Berg
2011-02-23 13:52 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).