From: Luciano Coelho <coelho@ti.com>
To: Sebastien Jan <s-jan@ti.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] WLAN: fix the path to the wl12xx firmwares
Date: Wed, 23 Feb 2011 16:33:19 +0200 [thread overview]
Message-ID: <1298471599.2104.44.camel@pimenta> (raw)
In-Reply-To: <1298467516-9092-1-git-send-email-s-jan@ti.com>
Hi Sebastien,
On Wed, 2011-02-23 at 14:25 +0100, Sebastien Jan wrote:
> Validated FW loading on a Ubuntu Natty alpha image, on a pandaboard
> (embedding a WL1271).
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
> ---
Thanks for working on getting the wl12xx driver to work on the
pandaboard!
> diff --git a/drivers/net/wireless/wl12xx/wl12xx.h b/drivers/net/wireless/wl12xx/wl12xx.h
> index 9050dd9..8ceb6a0 100644
> --- a/drivers/net/wireless/wl12xx/wl12xx.h
> +++ b/drivers/net/wireless/wl12xx/wl12xx.h
> @@ -112,8 +112,8 @@ extern u32 wl12xx_debug_level;
> CFG_RX_CTL_EN | CFG_RX_BCN_EN | \
> CFG_RX_AUTH_EN | CFG_RX_ASSOC_EN)
>
> -#define WL1271_FW_NAME "wl1271-fw.bin"
> -#define WL1271_NVS_NAME "wl1271-nvs.bin"
> +#define WL1271_FW_NAME "ti-connectivity/wl1271-fw.bin"
> +#define WL1271_NVS_NAME "ti-connectivity/wl1271-nvs.bin"
You're right. Our firmware is (unfortunately) inside the
ti-connectivity in linux-firmware.git. So it would make sense to
include the ti-connectivity/ directory when requesting for the firmware,
but it's just damn ugly. :( The driver should not care at all where the
firmware is to be fetched from, that should be up to the userspace.
Dunno what is the best thing to do about this. Add the directory to the
driver? Move the wl1271*.bin files to the root of linux-firmware? Does
anybody have opinions about it?
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-02-23 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:25 [PATCH] WLAN: fix the path to the wl12xx firmwares Sebastien Jan
2011-02-23 14:33 ` Luciano Coelho [this message]
2011-02-23 14:41 ` John W. Linville
2011-02-23 14:54 ` Luciano Coelho
2011-02-23 15:15 ` Larry Finger
2011-03-03 15:39 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298471599.2104.44.camel@pimenta \
--to=coelho@ti.com \
--cc=linux-wireless@vger.kernel.org \
--cc=s-jan@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).